mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 "Rafael J. Wysocki" <rafael@kernel.org>,
	Borislav Petkov <bp@alien8.de>,
	 linux-acpi@vger.kernel.org
Subject: [PATCH 8/9] ACPI: APEI: EINJ: Transition to the faux device interface
Date: Mon, 17 Mar 2025 10:13:20 +0000	[thread overview]
Message-ID: <20250317-plat2faux_dev-v1-8-5fe67c085ad5@arm.com> (raw)
In-Reply-To: <20250317-plat2faux_dev-v1-0-5fe67c085ad5@arm.com>

The APEI error injection driver does not require the creation of a
platform device. Originally, this approach was chosen for simplicity
when the driver was first implemented.

With the introduction of the lightweight faux device interface, we now
have a more appropriate alternative. Migrate the driver to utilize the
faux bus, given that the platform device it previously created was not
a real one anyway. This will simplify the code, reducing its footprint
while maintaining functionality.

Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: linux-acpi@vger.kernel.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/acpi/apei/einj-core.c | 32 +++++++++++---------------------
 1 file changed, 11 insertions(+), 21 deletions(-)

diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
index 04731a5b01faaba534bad853d0acc4c8a873a53b..7ff334422899e757de918107202507dd171d61da 100644
--- a/drivers/acpi/apei/einj-core.c
+++ b/drivers/acpi/apei/einj-core.c
@@ -21,7 +21,7 @@
 #include <linux/nmi.h>
 #include <linux/delay.h>
 #include <linux/mm.h>
-#include <linux/platform_device.h>
+#include <linux/device/faux.h>
 #include <linux/unaligned.h>
 
 #include "apei-internal.h"
@@ -749,7 +749,7 @@ static int einj_check_table(struct acpi_table_einj *einj_tab)
 	return 0;
 }
 
-static int __init einj_probe(struct platform_device *pdev)
+static int __init einj_probe(struct faux_device *fdev)
 {
 	int rc;
 	acpi_status status;
@@ -851,7 +851,7 @@ static int __init einj_probe(struct platform_device *pdev)
 	return rc;
 }
 
-static void __exit einj_remove(struct platform_device *pdev)
+static void __exit einj_remove(struct faux_device *fdev)
 {
 	struct apei_exec_context ctx;
 
@@ -872,34 +872,25 @@ static void __exit einj_remove(struct platform_device *pdev)
 	acpi_put_table((struct acpi_table_header *)einj_tab);
 }
 
-static struct platform_device *einj_dev;
+static struct faux_device *einj_dev;
 /*
  * einj_remove() lives in .exit.text. For drivers registered via
  * platform_driver_probe() this is ok because they cannot get unbound at
  * runtime. So mark the driver struct with __refdata to prevent modpost
  * triggering a section mismatch warning.
  */
-static struct platform_driver einj_driver __refdata = {
+static struct faux_device_ops einj_device_ops __refdata = {
+	.probe = einj_probe,
 	.remove = __exit_p(einj_remove),
-	.driver = {
-		.name = "acpi-einj",
-	},
 };
 
 static int __init einj_init(void)
 {
-	struct platform_device_info einj_dev_info = {
-		.name = "acpi-einj",
-		.id = -1,
-	};
-	int rc;
-
-	einj_dev = platform_device_register_full(&einj_dev_info);
-	if (IS_ERR(einj_dev))
-		return PTR_ERR(einj_dev);
+	einj_dev = faux_device_create("acpi-einj", NULL, &einj_device_ops);
+	if (!einj_dev)
+		return -ENODEV;
 
-	rc = platform_driver_probe(&einj_driver, einj_probe);
-	einj_initialized = rc == 0;
+	einj_initialized = true;
 
 	return 0;
 }
@@ -907,9 +898,8 @@ static int __init einj_init(void)
 static void __exit einj_exit(void)
 {
 	if (einj_initialized)
-		platform_driver_unregister(&einj_driver);
+		faux_device_destroy(einj_dev);
 
-	platform_device_unregister(einj_dev);
 }
 
 module_init(einj_init);

-- 
2.34.1


  parent reply	other threads:[~2025-03-17 10:14 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17 10:13 [PATCH 0/9] drivers: " Sudeep Holla
2025-03-17 10:13 ` [PATCH 1/9] cpuidle: psci: " Sudeep Holla
2025-04-09 18:03   ` Rafael J. Wysocki
2025-04-09 19:17     ` Sudeep Holla
2025-04-09 19:28       ` Rafael J. Wysocki
2025-03-17 10:13 ` [PATCH 2/9] hwrng: arm-smccc-trng - transition " Sudeep Holla
2025-03-17 13:04   ` Greg Kroah-Hartman
2025-03-17 14:22     ` Sudeep Holla
2025-03-17 14:30       ` Greg Kroah-Hartman
2025-03-17 14:43         ` Sudeep Holla
2025-03-17 16:46           ` Greg Kroah-Hartman
2025-03-17 16:53             ` Sudeep Holla
2025-03-17 10:13 ` [PATCH 3/9] efi: Remove redundant creation of the "efivars" platform device Sudeep Holla
2025-03-17 17:06   ` Ard Biesheuvel
2025-03-17 17:19     ` Sudeep Holla
2025-03-17 10:13 ` [PATCH 4/9] rtc: efi: Transition to the faux device interface Sudeep Holla
2025-03-17 13:07   ` Greg Kroah-Hartman
2025-03-17 14:04     ` Sudeep Holla
2025-03-17 10:13 ` [PATCH 5/9] virt: efi_secret: " Sudeep Holla
2025-03-17 13:06   ` Greg Kroah-Hartman
2025-03-17 10:13 ` [PATCH 6/9] ASoC: soc-utils: " Sudeep Holla
2025-03-17 10:13 ` [PATCH 7/9] net: phy: fixed_phy: transition " Sudeep Holla
2025-03-17 12:29   ` Andrew Lunn
2025-03-17 13:00     ` Greg Kroah-Hartman
2025-03-17 14:17     ` Sudeep Holla
2025-03-17 10:13 ` Sudeep Holla [this message]
2025-06-06  3:35   ` [PATCH 8/9] ACPI: APEI: EINJ: Transition " Dan Williams
2025-03-17 10:13 ` [PATCH 9/9] regulator: dummy: convert to use " Sudeep Holla
2025-03-17 10:24   ` Mark Brown
2025-03-17 10:34     ` Sudeep Holla
2025-03-17 13:00   ` Greg Kroah-Hartman
2025-03-17 14:13     ` Sudeep Holla
2025-03-17 14:26       ` Greg Kroah-Hartman
2025-03-17 14:30         ` Sudeep Holla
2025-03-17 13:01 ` [PATCH 0/9] drivers: Transition to " Greg Kroah-Hartman
2025-03-17 14:28   ` Sudeep Holla
2025-03-17 14:20 ` Mark Brown
2025-03-17 18:10 ` (subset) " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250317-plat2faux_dev-v1-8-5fe67c085ad5@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=bp@alien8.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®