mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Craig McQueen <craig@mcqueen.au>
To: linux-leds@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Craig McQueen <craig@mcqueen.au>
Subject: [PATCH v3 1/2] leds: uleds documentation fixes
Date: Mon, 17 Mar 2025 13:22:19 +1100	[thread overview]
Message-ID: <20250317022220.423966-1-craig@mcqueen.au> (raw)

* Add max_brightness field to struct for setup.
* Reads are a signed int value, not a single unsigned byte value.

Signed-off-by: Craig McQueen <craig@mcqueen.au>
---
 Documentation/leds/uleds.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/leds/uleds.rst b/Documentation/leds/uleds.rst
index 83221098009c..4077745dae00 100644
--- a/Documentation/leds/uleds.rst
+++ b/Documentation/leds/uleds.rst
@@ -17,16 +17,16 @@ structure to it (found in kernel public header file linux/uleds.h)::
 
     struct uleds_user_dev {
 	char name[LED_MAX_NAME_SIZE];
+	int max_brightness;
     };
 
 A new LED class device will be created with the name given. The name can be
 any valid sysfs device node name, but consider using the LED class naming
 convention of "devicename:color:function".
 
-The current brightness is found by reading a single byte from the character
-device. Values are unsigned: 0 to 255. Reading will block until the brightness
-changes. The device node can also be polled to notify when the brightness value
-changes.
+The current brightness is found by reading an int value from the character
+device. Reading will block until the brightness changes. The device node can
+also be polled to notify when the brightness value changes.
 
 The LED class device will be removed when the open file handle to /dev/uleds
 is closed.
-- 
2.48.1


             reply	other threads:[~2025-03-17  2:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17  2:22 Craig McQueen [this message]
2025-03-17  2:22 ` [PATCH v3 2/2] leds: Add some setup ioctls to uleds driver Craig McQueen
2025-04-04 12:30   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250317022220.423966-1-craig@mcqueen.au \
    --to=craig@mcqueen.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®