From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39ABC13C908; Tue, 18 Mar 2025 13:25:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742304320; cv=none; b=BazstfYxH1UrIdpq4xmOQHfED4wQmqkBjIgFGWW640p0YYd7Nbryqq4DSZ79Q/uPWJjzKz8+xTFxieuKJFhPV5KDnVs5QAbIyag6EFcRId+jzrYDnVNyedQmj6A1GhX3xP6Aw7aKpvY1eFu4cBbR0rV11uXc/PunSRbxEL6Kcow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742304320; c=relaxed/simple; bh=sm1Xz6loYNgAy8QDfYfj8lVAdZgMYiUz6arqfRBcYtw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fX5Ulz1j0qFtl5prQfYeiKrDz9oM0cUyXH0HBB0Ow90ZAdsa5EsikG5YjOxLH8Vusoj10fy3NR6tH2Iby55+sIPpPOPCZl8sC7FNOEzdWX5S3m34wmAfKjuXkubnB9FwVSdYR5OkkQZUTvPQ5Vnig51EIgio3+DZEtKlfrUlhC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ygKwZy0L; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ygKwZy0L" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1455C4CEDD; Tue, 18 Mar 2025 13:25:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1742304320; bh=sm1Xz6loYNgAy8QDfYfj8lVAdZgMYiUz6arqfRBcYtw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ygKwZy0Ltkda23XHQWr41ijJCDPu/R0US0cCFlMUlDEzQ6r2ThZ811+VvKDazMaWv W1L7EDE3LdYeIQozswMoggFQ2zd0ITil2wxSAS4v97hoZZ3O6Xa7fOuPLUZQrtcrHR HpMwX/NtAqfhINVXu/TTsoNZWBc3Nk4KJiCnOBqw= Date: Tue, 18 Mar 2025 14:24:01 +0100 From: Greg Kroah-Hartman To: Huacai Chen Cc: Sasha Levin , Huacai Chen , Xuerui Wang , stable@vger.kernel.org, David Howells , David Woodhouse , Jan Stancek , Jarkko Sakkinen , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, R Nageswara Sastry , Neal Gompa Subject: Re: [PATCH 6.1&6.6 1/3] sign-file,extract-cert: move common SSL helper functions to a header Message-ID: <2025031834-spotty-dipped-be36@gregkh> References: <20250318110124.2160941-1-chenhuacai@loongson.cn> <20250318110124.2160941-2-chenhuacai@loongson.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250318110124.2160941-2-chenhuacai@loongson.cn> On Tue, Mar 18, 2025 at 07:01:22PM +0800, Huacai Chen wrote: > From: Jan Stancek > > commit 300e6d4116f956b035281ec94297dc4dc8d4e1d3 upstream. > > Couple error handling helpers are repeated in both tools, so > move them to a common header. > > Signed-off-by: Jan Stancek > Reviewed-by: Jarkko Sakkinen > Tested-by: R Nageswara Sastry > Reviewed-by: Neal Gompa > Signed-off-by: Jarkko Sakkinen > Signed-off-by: Huacai Chen > --- Is this "v2" as well? the threading is all confusing here. This is what my inbox looks like right now: 32 N T Mar 18 Huacai Chen (2.9K) [PATCH 6.1&6.6 V2 0/3] sign-file,extract-cert: switch to PROVIDER API for OpenSSL >= 3.0 33 N T Mar 18 Huacai Chen (7.9K) ├─>[PATCH 6.1&6.6 V2 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3 34 N T Mar 18 Huacai Chen (3.4K) ├─>[PATCH 6.1&6.6 V2 2/3] sign-file,extract-cert: avoid using deprecated ERR_get_error_line() 35 N T Mar 18 Huacai Chen (4.8K) └─>[PATCH 6.1&6.6 1/3] sign-file,extract-cert: move common SSL helper functions to a header 46 N T Mar 18 Huacai Chen (2.9K) [PATCH 6.1&6.6 0/3] sign-file,extract-cert: switch to PROVIDER API for OpenSSL >= 3.0 47 N T Mar 18 Huacai Chen (3.3K) ├─>[PATCH 6.1&6.6 2/3] sign-file,extract-cert: avoid using deprecated ERR_get_error_line() 48 N T Mar 18 Huacai Chen (4.8K) ├─>[PATCH 6.1&6.6 1/3] sign-file,extract-cert: move common SSL helper functions to a header 50 N T Mar 18 Huacai Chen (7.8K) └─>[PATCH 6.1&6.6 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3 What would you do if you saw that? greg k-h