From: Antheas Kapenekakis <lkml@antheas.dev>
To: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <bentiss@kernel.org>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D . Jones" <luke@ljones.dev>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Antheas Kapenekakis" <lkml@antheas.dev>
Subject: [PATCH 02/11] HID: asus: cleanup keyboard backlight check
Date: Wed, 19 Mar 2025 20:13:10 +0100 [thread overview]
Message-ID: <20250319191320.10092-3-lkml@antheas.dev> (raw)
In-Reply-To: <20250319191320.10092-1-lkml@antheas.dev>
Currently, asus_kbd_get_functions does a set_report
to query for the keyboard backlight status using a varying
report id. However, it then does get_report with the fixed
id 0x5a. The ids of get_report and set_report should always
match. Therefore, remove the calling argument and force 0x5a.
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
drivers/hid/hid-asus.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index aa4a481dc4f27..bcc317057b465 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -427,10 +427,9 @@ static int asus_kbd_init(struct hid_device *hdev)
}
static int asus_kbd_get_functions(struct hid_device *hdev,
- unsigned char *kbd_func,
- u8 report_id)
+ unsigned char *kbd_func)
{
- const u8 buf[] = { report_id, 0x05, 0x20, 0x31, 0x00, 0x08 };
+ const u8 buf[] = { FEATURE_KBD_REPORT_ID, 0x05, 0x20, 0x31, 0x00, 0x08 };
u8 *readbuf;
int ret;
@@ -572,7 +571,7 @@ static int asus_kbd_register_leds(struct hid_device *hdev)
return ret;
/* Get keyboard functions */
- ret = asus_kbd_get_functions(hdev, &kbd_func, FEATURE_KBD_REPORT_ID);
+ ret = asus_kbd_get_functions(hdev, &kbd_func);
if (ret < 0)
return ret;
--
2.48.1
next prev parent reply other threads:[~2025-03-19 19:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 19:13 [PATCH 00/11] HID: asus: hid-asus and asus-wmi backlight unification, Z13 QOL improvements Antheas Kapenekakis
2025-03-19 19:13 ` [PATCH 01/11] HID: asus: refactor init sequence per spec Antheas Kapenekakis
2025-03-20 7:19 ` Luke D. Jones
2025-03-20 9:50 ` Antheas Kapenekakis
2025-03-20 11:47 ` Antheas Kapenekakis
2025-03-20 21:01 ` Luke D. Jones
2025-03-20 21:09 ` Antheas Kapenekakis
2025-03-19 19:13 ` Antheas Kapenekakis [this message]
2025-03-19 19:13 ` [PATCH 03/11] HID: asus: prevent binding to all HID devices on ROG Antheas Kapenekakis
2025-03-19 19:13 ` [PATCH 04/11] HID: asus: rename keyboard3 to Z13_FOLIO Antheas Kapenekakis
2025-03-22 1:31 ` Luke D. Jones
2025-03-19 19:13 ` [PATCH 05/11] HID: asus: add Asus Z13 2025 Fan key Antheas Kapenekakis
2025-03-19 19:13 ` [PATCH 06/11] HID: asus: introduce small delay on Asus Z13 RGB init Antheas Kapenekakis
2025-03-20 7:12 ` Luke D. Jones
2025-03-20 8:30 ` Antheas Kapenekakis
2025-03-20 21:03 ` Luke D. Jones
2025-03-19 19:13 ` [PATCH 07/11] platform/x86: asus-wmi: Add support for multiple kbd RGB handlers Antheas Kapenekakis
2025-03-19 19:13 ` [PATCH 08/11] HID: asus: listen to the asus-wmi brightness device instead of creating one Antheas Kapenekakis
2025-03-19 19:13 ` [PATCH 09/11] platform/x86: asus-wmi: remove unused keyboard backlight quirk Antheas Kapenekakis
2025-03-20 7:10 ` Luke D. Jones
2025-03-20 8:28 ` Antheas Kapenekakis
2025-03-19 19:13 ` [PATCH 10/11] platform/x86: asus-wmi: add keyboard brightness event handler Antheas Kapenekakis
2025-03-19 19:13 ` [PATCH 11/11] HID: asus: add support for the asus-wmi brightness handler Antheas Kapenekakis
2025-03-20 10:18 ` kernel test robot
2025-03-19 21:50 ` [PATCH 00/11] HID: asus: hid-asus and asus-wmi backlight unification, Z13 QOL improvements Antheas Kapenekakis
2025-03-20 6:09 ` Luke Jones
2025-03-20 8:26 ` Antheas Kapenekakis
2025-03-24 12:10 ` Hans de Goede
2025-03-24 12:25 ` Antheas Kapenekakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319191320.10092-3-lkml@antheas.dev \
--to=lkml@antheas.dev \
--cc=bentiss@kernel.org \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®