From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE52A22256C for ; Fri, 21 Mar 2025 11:13:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742555605; cv=none; b=tnad8MOsuKQWJOhmMLmPVPuTrsnbw9+bce9OMVpEeKuqaOIN3NPU+pMmpzccCBuwbS4AFaWhtcVtEWzAh2h1PFahtKQ/sehLwFIUOwA35YCEiPfs1xpgp0B0ilKFm+8QRrKAwaU9voEsPLtJ/SFzCd/Ic+tVgUmFJNTyNZHNOL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742555605; c=relaxed/simple; bh=2H9b5pMvFhbEH78r7pcO5KdNshEmaQ6Ex1B/37rxL54=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=muIMjyJnLleQDZEH+dvSZjwDkfEcYlKnPtsMm+HjSJYohUYNf2kc6BMRQwdlvVqvrbZzTXTUKecFRzOuYR3J/7RgAQEaLUPBpnrWhJEDfG72f1rNC9Wf2I2N4z/EFR0ilB/eiPCtP9wqsAyTXp3CCyXKojy2PwbwaFn3HCRRBxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ZK06v3R3Hz6L59y; Fri, 21 Mar 2025 19:08:23 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 48C35140517; Fri, 21 Mar 2025 19:13:20 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 21 Mar 2025 12:13:19 +0100 Date: Fri, 21 Mar 2025 11:13:18 +0000 From: Jonathan Cameron To: Yicong Yang CC: , , , , , , , , Subject: Re: [PATCH v2 3/8] drivers/perf: hisi: Use ACPI driver_data to retrieve SLLC PMU information Message-ID: <20250321111318.0000455e@huawei.com> In-Reply-To: <20250321073846.23507-4-yangyicong@huawei.com> References: <20250321073846.23507-1-yangyicong@huawei.com> <20250321073846.23507-4-yangyicong@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100011.china.huawei.com (7.191.174.247) To frapeml500008.china.huawei.com (7.182.85.71) On Fri, 21 Mar 2025 15:38:41 +0800 Yicong Yang wrote: > From: Junhao He > > Make use of struct acpi_device_id::driver_data for version specific > information rather than judge the version register. This will help > to simplify the probe process and also a bit easier for extension. > > Factor out SLLC register definition to struct hisi_sllc_pmu_regs. > No functional changes intended. > > Signed-off-by: Junhao He > Signed-off-by: Yicong Yang LGTM Reviewed-by: Jonathan Cameron