From: Yu-Chun Lin <eleanor15x@gmail.com>
To: isdn@linux-pingi.de, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jserv@ccns.ncku.edu.tw, visitorckw@gmail.com,
Yu-Chun Lin <eleanor15x@gmail.com>
Subject: [PATCH] mISDN: hfcsusb: Optimize performance by replacing rw_lock with spinlock
Date: Sat, 22 Mar 2025 01:20:24 +0800 [thread overview]
Message-ID: <20250321172024.3372381-1-eleanor15x@gmail.com> (raw)
The 'HFClock', an rwlock, is only used by writers, making it functionally
equivalent to a spinlock.
According to Documentation/locking/spinlocks.rst:
"Reader-writer locks require more atomic memory operations than simple
spinlocks. Unless the reader critical section is long, you are better
off just using spinlocks."
Since read_lock() is never called, switching to a spinlock reduces
overhead and improves efficiency.
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
---
Build tested only, as I don't have the hardware.
Ensured all rw_lock -> spinlock conversions are complete, and replacing
rw_lock with spinlock should always be safe.
drivers/isdn/hardware/mISDN/hfcsusb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
index e54419a4e731..5041d635ef7f 100644
--- a/drivers/isdn/hardware/mISDN/hfcsusb.c
+++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
@@ -27,7 +27,7 @@ static unsigned int debug;
static int poll = DEFAULT_TRANSP_BURST_SZ;
static LIST_HEAD(HFClist);
-static DEFINE_RWLOCK(HFClock);
+static DEFINE_SPINLOCK(HFClock);
MODULE_AUTHOR("Martin Bachem");
@@ -1895,9 +1895,9 @@ setup_instance(struct hfcsusb *hw, struct device *parent)
goto out;
hfcsusb_cnt++;
- write_lock_irqsave(&HFClock, flags);
+ spin_lock_irqsave(&HFClock, flags);
list_add_tail(&hw->list, &HFClist);
- write_unlock_irqrestore(&HFClock, flags);
+ spin_unlock_irqrestore(&HFClock, flags);
return 0;
out:
--
2.43.0
next reply other threads:[~2025-03-21 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 17:20 Yu-Chun Lin [this message]
2025-03-24 14:21 ` Simon Horman
2025-03-27 15:28 ` Yu-Chun Lin
2025-03-27 17:00 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250321172024.3372381-1-eleanor15x@gmail.com \
--to=eleanor15x@gmail.com \
--cc=isdn@linux-pingi.de \
--cc=jserv@ccns.ncku.edu.tw \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®