From: Yue Haibing <yuehaibing@huawei.com>
To: <hverkuil@xs4all.nl>, <mchehab@kernel.org>, <lumag@kernel.org>,
<dmitry.baryshkov@linaro.org>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<yuehaibing@huawei.com>, <dri-devel@lists.freedesktop.org>
Subject: [PATCH v2 -next] media: cec: tda9950: Add missing I2C dependency
Date: Sat, 22 Mar 2025 10:49:14 +0800 [thread overview]
Message-ID: <20250322024914.3622546-1-yuehaibing@huawei.com> (raw)
If CONFIG_I2C is not set, build fails:
drivers/media/cec/i2c/tda9950.c: In function ‘tda9950_probe’:
drivers/media/cec/i2c/tda9950.c:391:14: error: implicit declaration of function ‘i2c_check_functionality’ [-Werror=implicit-function-declaration]
if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
| ^~~~~~~~~~~~~~~~~~~~~~~
CC crypto/aes_generic.o
drivers/media/cec/i2c/tda9950.c: At top level:
drivers/media/cec/i2c/tda9950.c:503:1: warning: data definition has no type or storage class
503 | module_i2c_driver(tda9950_driver);
| ^~~~~~~~~~~~~~~~~
drivers/media/cec/i2c/tda9950.c:503:1: error: type defaults to ‘int’ in declaration of ‘module_i2c_driver’ [-Werror=implicit-int]
drivers/media/cec/i2c/tda9950.c:503:1: warning: parameter names (without types) in function declaration
Add missing I2C dependency to fix this.
Fixes: caa6f4a75e9f ("media: cec: move driver for TDA9950 from drm/i2c")
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
v2: Fix patch title, also cc dri-devel list
---
drivers/media/cec/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/cec/i2c/Kconfig b/drivers/media/cec/i2c/Kconfig
index b9d21643eef1..c31abc26f602 100644
--- a/drivers/media/cec/i2c/Kconfig
+++ b/drivers/media/cec/i2c/Kconfig
@@ -16,6 +16,7 @@ config CEC_CH7322
config CEC_NXP_TDA9950
tristate "NXP Semiconductors TDA9950/TDA998X HDMI CEC"
+ depends on I2C
select CEC_NOTIFIER
select CEC_CORE
default DRM_I2C_NXP_TDA998X
--
2.34.1
next reply other threads:[~2025-03-22 2:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 2:49 Yue Haibing [this message]
2025-03-22 3:40 ` Yue Haibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250322024914.3622546-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®