From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: "Mateusz Jończyk" <mat.jonczyk@o2.pl>,
"David Heidelberg" <david@ixit.cz>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH] x86/Kconfig: correct X86_X2APIC help text
Date: Sat, 22 Mar 2025 16:45:41 +0100 [thread overview]
Message-ID: <20250322154541.40325-1-mat.jonczyk@o2.pl> (raw)
In-Reply-To: <20250321-x86_x2apic-v3-1-b0cbaa6fa338@ixit.cz>
Currently, it is not true that the kernel will panic with CONFIG_X86_X2APIC=n
on systems that require it; it will try to disable the APIC and run without
it to at least give the user a clear warning message. See the second
variant of check_x2apic() in arch/x86/kernel/apic/apic.c .
Also massage some other parts of the help text.
Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
Fixes: 9232c49ff31c ("x86/Kconfig: Enable X86_X2APIC by default and improve help text")
Cc: David Heidelberg <david@ixit.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
---
This patch fixes a patch currently in tip.git master and depends on it.
I have not verified recently that the kernel will work at all without
CONFIG_X86_X2APIC on systems which force enable it - but it was working
in 2022.
---
arch/x86/Kconfig | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index e72cb7779038..ef48584c8889 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -471,14 +471,15 @@ config X86_X2APIC
in 2019, but it can be disabled by the BIOS. It is also frequently
emulated in virtual machines, even when the host CPU does not support
it. Support in the CPU can be checked by executing
- cat /proc/cpuinfo | grep x2apic
+ grep x2apic /proc/cpuinfo
- If this configuration option is disabled, the kernel will not boot on
- some platforms that have x2APIC enabled.
+ If this configuration option is disabled, the kernel will boot with
+ very reduced functionality and performance on some platforms that
+ have x2APIC enabled. On the other hand, on hardware that does not
+ support x2APIC, a kernel with this option enabled will just fallback
+ to older APIC implementations.
- Say N if you know that your platform does not have x2APIC.
-
- Otherwise, say Y.
+ If in doubt, say Y.
config X86_POSTED_MSI
bool "Enable MSI and MSI-x delivery by posted interrupts"
--
2.25.1
next prev parent reply other threads:[~2025-03-22 15:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 20:48 [PATCH v3 0/7] x86: Kconfig cleanups and help text improvements David Heidelberg via B4 Relay
2025-03-21 20:48 ` [PATCH v3 1/7] x86/Kconfig: Enable X86_X2APIC by default and improve help text David Heidelberg via B4 Relay
2025-03-22 15:45 ` Mateusz Jończyk [this message]
2025-03-25 7:36 ` [tip: x86/urgent] x86/Kconfig: Correct X86_X2APIC " tip-bot2 for Mateusz Jończyk
2025-03-25 7:36 ` [tip: x86/urgent] x86/Kconfig: Enable X86_X2APIC by default and improve " tip-bot2 for Mateusz Jończyk
2025-03-21 20:48 ` [PATCH v3 2/7] x86/Kconfig: Always enable ARCH_SPARSEMEM_ENABLE David Heidelberg via B4 Relay
2025-03-25 7:36 ` [tip: x86/urgent] " tip-bot2 for Mateusz Jończyk
2025-03-21 20:48 ` [PATCH v3 3/7] x86/Kconfig: Move all X86_EXTENDED_PLATFORM options together David Heidelberg via B4 Relay
2025-03-25 7:36 ` [tip: x86/urgent] " tip-bot2 for Mateusz Jończyk
2025-03-21 20:48 ` [PATCH v3 4/7] x86/Kconfig: Update lists in X86_EXTENDED_PLATFORM David Heidelberg via B4 Relay
2025-03-22 17:50 ` [PATCH] x86/Kconfig: fix lists in X86_EXTENDED_PLATFORM help text Mateusz Jończyk
2025-03-23 3:14 ` Andy Shevchenko
2025-03-25 7:22 ` Ingo Molnar
2025-03-25 14:14 ` Andy Shevchenko
2025-03-25 7:36 ` [tip: x86/urgent] x86/Kconfig: Fix " tip-bot2 for Mateusz Jończyk
2025-03-25 7:36 ` [tip: x86/urgent] x86/Kconfig: Update lists in X86_EXTENDED_PLATFORM tip-bot2 for Mateusz Jończyk
2025-03-21 20:48 ` [PATCH v3 5/7] x86/Kconfig: Document CONFIG_PCI_MMCONFIG David Heidelberg via B4 Relay
2025-03-22 7:11 ` Ingo Molnar
2025-03-25 7:36 ` [tip: x86/urgent] " tip-bot2 for Mateusz Jończyk
2025-03-21 20:48 ` [PATCH v3 6/7] x86/Kconfig: Make CONFIG_PCI_CNB20LE_QUIRK depend on X86_32 David Heidelberg via B4 Relay
2025-03-25 7:36 ` [tip: x86/urgent] " tip-bot2 for Mateusz Jończyk
2025-03-21 20:48 ` [PATCH v3 7/7] x86/Kconfig: Document release year of glibc 2.3.3 David Heidelberg via B4 Relay
2025-03-22 7:28 ` Ingo Molnar
2025-03-25 7:36 ` [tip: x86/urgent] " tip-bot2 for Mateusz Jończyk
2025-03-22 15:13 ` [PATCH v3 0/7] x86: Kconfig cleanups and help text improvements Mateusz Jończyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250322154541.40325-1-mat.jonczyk@o2.pl \
--to=mat.jonczyk@o2.pl \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@ixit.cz \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®