mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	 Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	 Linus Walleij <linus.walleij@linaro.org>,
	 Bartosz Golaszewski <brgl@bgdev.pl>,
	 Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	 Steev Klimaszewski <steev@kali.org>,
	Johan Hovold <johan@kernel.org>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	 Peng Fan <peng.fan@nxp.com>
Subject: [PATCH v2 0/3] ASoC: codec: wcd93xx: Convert to GPIO descriptors
Date: Mon, 24 Mar 2025 19:51:26 +0800	[thread overview]
Message-ID: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> (raw)

Steev,
 I would appreciate if you have time to help test again.
 Hope V2 could work on your platform.

Linus,
 Since v2 is only a minor change to use GPIOD_OUT_LOW to replace
 GPIOD_ASIS when devm_gpio_get, so I still keep you R-b. Appreciate
 for your quick action.

Johan,
 Thanks for help look into V1. Appreciate if you have time to look
 into v2.

Sorry for this quick V2, there is no rush, but just wanna to avoid sending
this out in coming merge window.

of_gpio.h is deprecated, so update driver to use gpiod API.

The current driver use value 0 to assert reset and 1 to deassert reset.
The DTSes in tree that use the codec are using GPIO_ACTIVE_LOW.
So it is safe to use devm_gpiod_get to get GPIO descriptors and
use gpiod_set_value to configure output with value 1 means raw value
0, value 0 means raw value 1.

Note:
I not have devices to test, just my best pratice to do the convertion.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Changes in v2:
- Use GPIOD_OUT_LOW to replace GPIOD_ASIS to configure direction.
- Update commit log with "in-tree DTS files have the right polarity set up
  already so we can expect this to "just work"".
- Link to v1: https://lore.kernel.org/r/20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com

---
Peng Fan (3):
      ASoC: codec: wcd939x: Convert to GPIO descriptors
      ASoC: codec: wcd938x: Convert to GPIO descriptors
      ASoC: codec: wcd9335: Convert to GPIO descriptors

 sound/soc/codecs/wcd9335.c | 15 +++++++--------
 sound/soc/codecs/wcd938x.c | 13 ++++++-------
 sound/soc/codecs/wcd939x.c | 16 ++++++++--------
 3 files changed, 21 insertions(+), 23 deletions(-)
---
base-commit: 9388ec571cb1adba59d1cded2300eeb11827679c
change-id: 20250324-wcd-gpiod-782c4a0d8688

Best regards,
-- 
Peng Fan <peng.fan@nxp.com>


             reply	other threads:[~2025-03-24 11:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-24 11:51 Peng Fan (OSS) [this message]
2025-03-24 11:51 ` [PATCH v2 1/3] ASoC: codec: wcd939x: " Peng Fan (OSS)
2025-03-27  8:50   ` Bartosz Golaszewski
2025-03-24 11:51 ` [PATCH v2 2/3] ASoC: codec: wcd938x: " Peng Fan (OSS)
2025-03-24 15:38   ` Steev Klimaszewski
2025-03-25  0:35     ` Peng Fan
2025-03-27  8:50   ` Bartosz Golaszewski
2025-03-24 11:51 ` [PATCH v2 3/3] ASoC: codec: wcd9335: " Peng Fan (OSS)
2025-03-27  8:50   ` Bartosz Golaszewski
2025-04-08 12:48 ` [PATCH v2 0/3] ASoC: codec: wcd93xx: " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com \
    --to=peng.fan@oss.nxp.com \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=johan@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=perex@perex.cz \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=steev@kali.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®