From: Joel Fernandes <joelagnelf@nvidia.com>
To: linux-kernel@vger.kernel.org,
"Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>,
Josh Triplett <josh@joshtriplett.org>,
Boqun Feng <boqun.feng@gmail.com>,
Uladzislau Rezki <urezki@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Zqiang <qiang.zhang1211@gmail.com>
Cc: Joel Fernandes <joelagnelf@nvidia.com>, rcu@vger.kernel.org
Subject: [PATCH 2/3] rcu: Add warning to ensure rcu_seq_done_exact() is working
Date: Mon, 24 Mar 2025 13:01:54 -0400 [thread overview]
Message-ID: <20250324170156.469763-3-joelagnelf@nvidia.com> (raw)
In-Reply-To: <20250324170156.469763-1-joelagnelf@nvidia.com>
The previous patch improved the rcu_seq_done_exact() function by adding
a meaningful constant for the guardband.
Ensure that this is working for the future by a quick check during
rcu_gp_init().
Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
---
kernel/rcu/tree.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 659f83e71048..29ddbcbea25e 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1798,6 +1798,7 @@ static noinline_for_stack bool rcu_gp_init(void)
struct rcu_data *rdp;
struct rcu_node *rnp = rcu_get_root();
bool start_new_poll;
+ unsigned long old_gp_seq;
WRITE_ONCE(rcu_state.gp_activity, jiffies);
raw_spin_lock_irq_rcu_node(rnp);
@@ -1825,7 +1826,11 @@ static noinline_for_stack bool rcu_gp_init(void)
*/
start_new_poll = rcu_sr_normal_gp_init();
/* Record GP times before starting GP, hence rcu_seq_start(). */
+ old_gp_seq = rcu_state.gp_seq;
rcu_seq_start(&rcu_state.gp_seq);
+ /* Ensure that rcu_seq_done_exact() guardband doesn't give false positives. */
+ WARN_ON_ONCE(rcu_seq_done_exact(&old_gp_seq, rcu_seq_snap(&rcu_state.gp_seq)));
+
ASSERT_EXCLUSIVE_WRITER(rcu_state.gp_seq);
trace_rcu_grace_period(rcu_state.name, rcu_state.gp_seq, TPS("start"));
rcu_poll_gp_seq_start(&rcu_state.gp_seq_polled_snap);
--
2.43.0
next prev parent reply other threads:[~2025-03-24 17:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 17:01 [PATCH 0/3] rcu_seq_done_exact() improvements Joel Fernandes
2025-03-24 17:01 ` [PATCH 1/3] rcu: Replace magic number with meaningful constant in rcu_seq_done_exact() Joel Fernandes
2025-03-26 22:33 ` Paul E. McKenney
2025-03-26 22:42 ` Joel Fernandes
2025-03-27 17:09 ` Paul E. McKenney
2025-03-28 2:31 ` Joel Fernandes
2025-03-30 22:10 ` Frederic Weisbecker
2025-03-31 18:28 ` Paul E. McKenney
2025-03-31 21:14 ` Frederic Weisbecker
2025-03-31 21:29 ` Paul E. McKenney
2025-04-01 13:38 ` Frederic Weisbecker
2025-04-02 4:24 ` Paul E. McKenney
2025-03-24 17:01 ` Joel Fernandes [this message]
2025-03-26 22:36 ` [PATCH 2/3] rcu: Add warning to ensure rcu_seq_done_exact() is working Paul E. McKenney
2025-03-26 22:50 ` Joel Fernandes
2025-03-26 23:21 ` Paul E. McKenney
2025-03-24 17:01 ` [PATCH 3/3] rcu: Comment on the extraneous delta test on rcu_seq_done_exact() Joel Fernandes
2025-03-26 22:37 ` Paul E. McKenney
2025-03-26 22:51 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324170156.469763-3-joelagnelf@nvidia.com \
--to=joelagnelf@nvidia.com \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=paulmck@kernel.org \
--cc=qiang.zhang1211@gmail.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®