From: Aditya Garg <adityagarg1208@gmail.com>
To: jikos@kernel.org, jkosina@suse.com, bentiss@kernel.org,
benjamin.tissoires@redhat.com
Cc: g.sokol99@g-sokol.info, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, gargaditya08@live.com
Subject: [PATCH v3 1/5] HID: apple: move backlight report structs to other backlight structs
Date: Tue, 25 Mar 2025 11:05:23 +0000 [thread overview]
Message-ID: <20250325110754.28359-2-gargaditya08@live.com> (raw)
In-Reply-To: <20250325110754.28359-1-gargaditya08@live.com>
The apple_backlight_config_report and apple_backlight_set_report structs
were incorrectly placed between the translation tables. Fix this.
Signed-off-by: Aditya Garg <gargaditya08@live.com>
---
drivers/hid/hid-apple.c | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index d900dd05c..93b990603 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -89,6 +89,19 @@ struct apple_sc_backlight {
struct hid_device *hdev;
};
+struct apple_backlight_config_report {
+ u8 report_id;
+ u8 version;
+ u16 backlight_off, backlight_on_min, backlight_on_max;
+};
+
+struct apple_backlight_set_report {
+ u8 report_id;
+ u8 version;
+ u16 backlight;
+ u16 rate;
+};
+
struct apple_magic_backlight {
struct led_classdev cdev;
struct hid_report *brightness;
@@ -152,20 +165,6 @@ static const struct apple_key_translation magic_keyboard_2015_fn_keys[] = {
{ }
};
-struct apple_backlight_config_report {
- u8 report_id;
- u8 version;
- u16 backlight_off, backlight_on_min, backlight_on_max;
-};
-
-struct apple_backlight_set_report {
- u8 report_id;
- u8 version;
- u16 backlight;
- u16 rate;
-};
-
-
static const struct apple_key_translation apple2021_fn_keys[] = {
{ KEY_BACKSPACE, KEY_DELETE },
{ KEY_ENTER, KEY_INSERT },
--
2.49.0
next prev parent reply other threads:[~2025-03-25 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 11:05 [PATCH v3 0/5] HID: apple: combine patch series for all patches recently sent upstream Aditya Garg
2025-03-25 11:05 ` Aditya Garg [this message]
2025-03-25 11:05 ` [PATCH v3 2/5] HID: apple: use switch case to set fn translation table Aditya Garg
2025-03-25 11:05 ` [PATCH v3 3/5] HID: apple: remove unused APPLE_IGNORE_MOUSE quirk Aditya Garg
2025-03-25 11:05 ` [PATCH v3 4/5] HID: apple: Add Apple Magic Keyboard A3118 USB-C support Aditya Garg
2025-03-25 11:05 ` [PATCH v3 5/5] HID: apple: Add Apple Magic Keyboard A3119 " Aditya Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325110754.28359-2-gargaditya08@live.com \
--to=adityagarg1208@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bentiss@kernel.org \
--cc=g.sokol99@g-sokol.info \
--cc=gargaditya08@live.com \
--cc=jikos@kernel.org \
--cc=jkosina@suse.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®