From: Andy Yan <andyshrk@163.com>
To: heiko@sntech.de
Cc: conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
hjc@rock-chips.com, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Andy Yan <andy.yan@rock-chips.com>
Subject: [PATCH v2 0/6] Two fixes of RK3036 HDMI
Date: Tue, 25 Mar 2025 21:29:34 +0800 [thread overview]
Message-ID: <20250325132944.171111-1-andyshrk@163.com> (raw)
From: Andy Yan <andy.yan@rock-chips.com>
When preparing to convert the current inno hdmi driver into a bridge driver,
I found that there are several issues currently existing with it:
1. When the system starts up, the first time it reads the EDID, it will
fail.
This is because RK3036 HDMI DDC bus requires it's PHY's reference clock
to be enabled first before normal DDC communication can be carried out.
2. The signal is unstable. When running the glmark2 test on the screen,
there is a small probability of seeing some screen flickering.
This is because The HSYNC/VSYNC polarity of rk3036 HDMI are controlled
by GRF. This part is missing in the current driver.
This series first try to Fix Document in the dt-binding, then add the
missing part in driver and dts.
Changes in v2:
- Included the HSYNC/VSYNC polarity fix
Andy Yan (6):
dt-bindings: display: rockchip,inno-hdmi: Fix Document of RK3036
compatible
dt-bindings: display: rockchip,inno-hdmi: Document GRF for RK3036 HDMI
drm/rockchip: inno-hdmi: Simplify error handler with dev_err_probe
drm/rockchip: inno-hdmi: Fix video timing HSYNC/VSYNC polarity setting
for rk3036
ARM: dts: rockchip: Add ref clk for hdmi
Revert "ARM: dts: rockchip: drop grf reference from rk3036 hdmi"
.../display/rockchip/rockchip,inno-hdmi.yaml | 20 ++++---
arch/arm/boot/dts/rockchip/rk3036.dtsi | 5 +-
drivers/gpu/drm/rockchip/inno_hdmi.c | 55 ++++++++++++++-----
3 files changed, 55 insertions(+), 25 deletions(-)
--
2.43.0
next reply other threads:[~2025-03-25 13:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 13:29 Andy Yan [this message]
2025-03-25 13:29 ` [PATCH v2 1/6] dt-bindings: display: rockchip,inno-hdmi: Fix Document of RK3036 compatible Andy Yan
2025-03-25 13:29 ` [PATCH v2 2/6] dt-bindings: display: rockchip,inno-hdmi: Document GRF for RK3036 HDMI Andy Yan
2025-03-26 7:59 ` Krzysztof Kozlowski
2025-03-26 8:10 ` Andy Yan
2025-03-25 13:29 ` [PATCH v2 3/6] drm/rockchip: inno-hdmi: Simplify error handler with dev_err_probe Andy Yan
2025-03-25 13:29 ` [PATCH v2 4/6] drm/rockchip: inno-hdmi: Fix video timing HSYNC/VSYNC polarity setting for rk3036 Andy Yan
2025-03-25 13:29 ` [PATCH v2 5/6] ARM: dts: rockchip: Add ref clk for hdmi Andy Yan
2025-03-25 13:29 ` [PATCH v2 6/6] Revert "ARM: dts: rockchip: drop grf reference from rk3036 hdmi" Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325132944.171111-1-andyshrk@163.com \
--to=andyshrk@163.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®