mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konradybcio@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	cros-qcom-dts-watchers@chromium.org,
	 Marc Gonzalez <mgonzalez@freebox.fr>,
	Dmitry Baryshkov <lumag@kernel.org>,
	 Arnaud Vrac <avrac@freebox.fr>,
	Sayali Lokhande <quic_sayalil@quicinc.com>,
	 Xin Liu <quic_liuxin@quicinc.com>,
	 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
	 linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	 Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	 Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: [PATCH v2 04/12] arm64: dts: qcom: msm8998: Remove mdss_hdmi_phy phandle argument
Date: Thu, 27 Mar 2025 02:47:06 +0100	[thread overview]
Message-ID: <20250327-topic-more_dt_bindings_fixes-v2-4-b763d958545f@oss.qualcomm.com> (raw)
In-Reply-To: <20250327-topic-more_dt_bindings_fixes-v2-0-b763d958545f@oss.qualcomm.com>

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

The node has #clock-cells = <0>, as it only provides a single clock
output.

This leads to a turbo sneaky bug, where the dt checker shows that we
have additional clocks in the array:

clock-controller@c8c0000: clocks: [[3, 0], [39, 178], [156, 1],
[156, 0], [157, 1], [157, 0], [158], [0], [0], [0], [39, 184]]
is too long

..which happens due to dtc interpreting <&mdss_hdmi_phy 0> as
<&mdss_hdmi_phy>, <0> after taking cells into account.

Remove the superfluous argument to both silence the warning and fix
the index-based lookup of subsequent entries in "clocks".

Fixes: 2150c87db80c ("arm64: dts: qcom: msm8998: add HDMI nodes")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index c2caad85c668df2ebe900bc560e39480ae03e353..8d5a8a3f2c12ee1bc742c7dad35368f140d81dd2 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -2794,7 +2794,7 @@ mmcc: clock-controller@c8c0000 {
 				 <&mdss_dsi0_phy 0>,
 				 <&mdss_dsi1_phy 1>,
 				 <&mdss_dsi1_phy 0>,
-				 <&mdss_hdmi_phy 0>,
+				 <&mdss_hdmi_phy>,
 				 <0>,
 				 <0>,
 				 <&gcc GCC_MMSS_GPLL0_DIV_CLK>;

-- 
2.49.0


  parent reply	other threads:[~2025-03-27  1:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-27  1:47 [PATCH v2 00/12] More more dt-bindings fixes for arm64/qcom Konrad Dybcio
2025-03-27  1:47 ` [PATCH v2 01/12] dt-bindings: soc: qcom,rpmh-rsc: Limit power-domains requirement Konrad Dybcio
2025-03-27  8:18   ` Krzysztof Kozlowski
2025-03-27  1:47 ` [PATCH v2 02/12] arm64: dts: qcom: sc7180: Add specific APPS RSC compatible Konrad Dybcio
2025-03-27  1:47 ` [PATCH v2 03/12] arm64: dts: qcom: sdm845: " Konrad Dybcio
2025-03-27  1:47 ` Konrad Dybcio [this message]
2025-03-27  1:47 ` [PATCH v2 05/12] arm64: dts: qcom: qcs615: Remove disallowed property from AOSS_QMP node Konrad Dybcio
2025-03-27  1:47 ` [PATCH v2 06/12] arm64: dts: qcom: msm8998-fxtec: Add QUSB2PHY VDD supply Konrad Dybcio
2025-03-27  1:47 ` [PATCH v2 07/12] arm64: dts: qcom: msm8998-mtp: " Konrad Dybcio
2025-03-27  1:47 ` [PATCH v2 08/12] arm64: dts: qcom: msm8998-yoshino: " Konrad Dybcio
2025-03-27  1:47 ` [PATCH v2 09/12] arm64: dts: qcom: sm6350-pdx213: Wire up USB regulators Konrad Dybcio
2025-03-27 10:08   ` Dmitry Baryshkov
2025-03-27 10:11   ` Dmitry Baryshkov
2025-03-27  1:47 ` [PATCH v2 10/12] arm64: dts: qcom: msm8996-oneplus: Add SLPI VDD_PX Konrad Dybcio
2025-03-27 12:10   ` Dmitry Baryshkov
2025-03-27  1:47 ` [PATCH v2 11/12] arm64: dts: qcom: sa8775p: Clean up the PSCI PDs Konrad Dybcio
2025-03-27 14:00   ` Dmitry Baryshkov
2025-03-27 14:06     ` Konrad Dybcio
2025-03-27  1:47 ` [PATCH v2 12/12] arm64: dts: qcom: qcs615: Fix up UFS clocks Konrad Dybcio
2025-03-27 14:00   ` Dmitry Baryshkov
2025-05-20  2:14 ` [PATCH v2 00/12] More more dt-bindings fixes for arm64/qcom Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250327-topic-more_dt_bindings_fixes-v2-4-b763d958545f@oss.qualcomm.com \
    --to=konradybcio@kernel.org \
    --cc=andersson@kernel.org \
    --cc=avrac@freebox.fr \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=marijn.suijten@somainline.org \
    --cc=mgonzalez@freebox.fr \
    --cc=quic_liuxin@quicinc.com \
    --cc=quic_sayalil@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®