From: Vitaliy Shevtsov <v.shevtsov@mt-integration.ru>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
<UNGLinuxDriver@microchip.com>, "Andrew Lunn" <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>
Subject: Re: [PATCH v2] net: dsa: felix: check felix_cpu_port_for_conduit() for failure
Date: Thu, 27 Mar 2025 00:30:08 +0500 [thread overview]
Message-ID: <20250327003008.cb7282960ade3c1821702c31@mt-integration.ru> (raw)
In-Reply-To: <20250326192259.e3m7ydgkeo2ix6wb@skbuf>
On Wed, 26 Mar 2025 21:22:59 +0200, Vladimir Oltean wrote:
> Hello Vitaliy,
>
> If the bonding interface has no ports, it is not a DSA conduit.
>
> See the logic in dsa_conduit_changeupper() which, starting from "dev"
> which is known to be a DSA conduit, it looks at info->upper_dev which is
> a LAG device, and calls dsa_conduit_lag_join() when it is linking with
> it. Thus, the LAG device (info->upper_dev) has at least one port: dev.
>
> Also see this comment and walk through the dsa_conduit_lag_leave() path:
>
> /* If the LAG DSA conduit has no ports left, migrate back all
> * user ports to the first physical CPU port
> */
>
> Given the justification provided thus far, I don't see a reason to merge
> this patch. The "somehow it fails" needs to be a bit more clear.
Hello, Vladimir.
Okay then. Pretty clear, thanks.
--
Vitaliy Shevtsov <v.shevtsov@mt-integration.ru>
prev parent reply other threads:[~2025-03-26 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 18:34 Vitaliy Shevtsov
2025-03-26 19:22 ` Vladimir Oltean
2025-03-26 19:30 ` Vitaliy Shevtsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250327003008.cb7282960ade3c1821702c31@mt-integration.ru \
--to=v.shevtsov@mt-integration.ru \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®