From: Tarang Raval <tarang.raval@siliconsignals.io>
To: sakari.ailus@linux.intel.com, kieran.bingham@ideasonboard.com
Cc: Shravan.Chippa@microchip.com,
Tarang Raval <tarang.raval@siliconsignals.io>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Zhi Mao <zhi.mao@mediatek.com>,
Julien Massot <julien.massot@collabora.com>,
Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
Luis Garcia <git@luigi311.com>,
Mikhail Rudenko <mike.rudenko@gmail.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/9] media: i2c: imx334: Remove redundant register entries
Date: Sat, 29 Mar 2025 11:13:25 +0530 [thread overview]
Message-ID: <20250329054335.19931-4-tarang.raval@siliconsignals.io> (raw)
In-Reply-To: <20250329054335.19931-1-tarang.raval@siliconsignals.io>
IMX334_REG_{ADBIT, MDBIT, ADBIT1}: Already written in
imx334_set_framefmt function.
IMX334_REG_THSPREPARE: Unnecessary repeated writes removed.
CCI_REG8(0x3e04): Unnecessary repeated writes removed.
Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io>
---
drivers/media/i2c/imx334.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index 0785bf213d91..9d4d15df8dcf 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -226,7 +226,6 @@ static const struct cci_reg_sequence common_mode_regs[] = {
{ IMX334_REG_OPB_SIZE_V, 0x00 },
{ IMX334_REG_HREVERSE, 0x00 },
{ IMX334_REG_VREVERSE, 0x00 },
- { IMX334_REG_ADBIT, 0x00 },
{ IMX334_REG_UNREAD_PARAM5, 0x0000 },
{ IMX334_REG_UNREAD_PARAM6, 0x0008 },
{ IMX334_REG_XVS_XHS_OUTSEL, 0x20 },
@@ -239,19 +238,13 @@ static const struct cci_reg_sequence common_mode_regs[] = {
{ IMX334_REG_INCKSEL4, 0x7e },
{ IMX334_REG_SYS_MODE, 0x02 },
{ IMX334_REG_HADD_VADD, 0x00 },
- { IMX334_REG_MDBIT, 0x00 },
{ IMX334_REG_VALID_EXPAND, 0x03 },
{ IMX334_REG_TCYCLE, 0x00 },
- { IMX334_REG_ADBIT1, 0x01ff },
{ IMX334_REG_LANEMODE, 0x03 },
{ IMX334_REG_TCLKPOST, 0x007f },
{ IMX334_REG_TCLKPREPARE, 0x0037 },
{ IMX334_REG_TCLKTRAIL, 0x0037 },
{ IMX334_REG_TCLKZERO, 0xf7 },
- { IMX334_REG_THSPREPARE, 0x003f },
- { IMX334_REG_THSPREPARE, 0x006f },
- { IMX334_REG_THSPREPARE, 0x003f },
- { IMX334_REG_THSPREPARE, 0x005f },
{ IMX334_REG_THSPREPARE, 0x002f },
{ CCI_REG8(0x3078), 0x02 },
{ CCI_REG8(0x3079), 0x00 },
@@ -339,7 +332,6 @@ static const struct cci_reg_sequence common_mode_regs[] = {
{ CCI_REG8(0x37b0), 0x37 },
{ CCI_REG8(0x3e04), 0x0e },
{ IMX334_REG_AGAIN, 0x0050 },
- { CCI_REG8(0x3e04), 0x0e },
{ IMX334_REG_MASTER_MODE, 0x00 },
};
--
2.34.1
next prev parent reply other threads:[~2025-03-29 5:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 5:43 [PATCH v2 0/9] media: i2c: imx334: Miscellaneous cleanups and improvements Tarang Raval
2025-03-29 5:43 ` [PATCH v2 1/9] media: i2c: imx334: Simplify with dev_err_probe() Tarang Raval
2025-03-29 5:43 ` [PATCH v2 2/9] media: i2c: imx334: Convert to CCI register access helpers Tarang Raval
2025-03-29 5:43 ` Tarang Raval [this message]
2025-03-29 5:43 ` [PATCH v2 4/9] media: i2c: imx334: Configure lane mode Dynamically Tarang Raval
2025-03-29 5:43 ` [PATCH v2 5/9] media: i2c: imx334: Fix power management and control handling Tarang Raval
2025-03-29 5:43 ` [PATCH v2 6/9] media: i2c: imx334: Fix runtime PM handling in remove function Tarang Raval
2025-03-29 5:43 ` [PATCH v2 7/9] media: i2c: imx334: Enable runtime PM before sub-device registration Tarang Raval
2025-03-29 5:43 ` [PATCH v2 8/9] media: i2c: imx334: Use subdev state lock for synchronization Tarang Raval
2025-03-29 5:43 ` [PATCH v2 9/9] media: i2c: imx334: switch to {enable,disable}_streams Tarang Raval
2025-04-15 9:23 ` [PATCH v2 0/9] media: i2c: imx334: Miscellaneous cleanups and improvements Tarang Raval
2025-04-25 5:54 ` sakari.ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250329054335.19931-4-tarang.raval@siliconsignals.io \
--to=tarang.raval@siliconsignals.io \
--cc=Shravan.Chippa@microchip.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=git@luigi311.com \
--cc=hverkuil@xs4all.nl \
--cc=julien.massot@collabora.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mike.rudenko@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=zhi.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®