From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Ryo Takakura <ryotkkr98@gmail.com>
Cc: alex@ghiti.fr, aou@eecs.berkeley.edu, gregkh@linuxfoundation.org,
jirislaby@kernel.org, john.ogness@linutronix.de,
palmer@dabbelt.com, paul.walmsley@sifive.com, pmladek@suse.com,
samuel.holland@sifive.com, conor.dooley@microchip.com,
u.kleine-koenig@baylibre.com, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 2/2] serial: sifive: Switch to nbcon console
Date: Mon, 31 Mar 2025 10:03:18 +0200 [thread overview]
Message-ID: <20250331080318.BdZQodhu@linutronix.de> (raw)
In-Reply-To: <20250330112109.393526-1-ryotkkr98@gmail.com>
On 2025-03-30 20:21:09 [+0900], Ryo Takakura wrote:
> --- a/drivers/tty/serial/sifive.c
> +++ b/drivers/tty/serial/sifive.c
> @@ -785,33 +786,88 @@ static void sifive_serial_console_putchar(struct uart_port *port, unsigned char
>
> __ssp_wait_for_xmitr(ssp);
> __ssp_transmit_char(ssp, ch);
> +
> + ssp->console_line_ended = (ch == '\n');
> +}
> +
> +static void sifive_serial_device_lock(struct console *co, unsigned long *flags)
> +{
> + struct uart_port *up = &sifive_serial_console_ports[co->index]->port;
> +
> + return __uart_port_lock_irqsave(up, flags);
this does look odd. A return statement in a return-void function. The
imx driver started it…
> +}
> +
> +static void sifive_serial_device_unlock(struct console *co, unsigned long flags)
> +{
> + struct uart_port *up = &sifive_serial_console_ports[co->index]->port;
> +
> + return __uart_port_unlock_irqrestore(up, flags);
> }
Sebastian
next prev parent reply other threads:[~2025-03-31 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-30 11:09 [PATCH v3 0/2] serial: sifive: Convert sifive console to nbcon Ryo Takakura
2025-03-30 11:15 ` [PATCH v3 1/2] serial: sifive: lock port in startup()/shutdown() callbacks Ryo Takakura
2025-03-30 11:21 ` [PATCH v3 2/2] serial: sifive: Switch to nbcon console Ryo Takakura
2025-03-31 8:03 ` Sebastian Andrzej Siewior [this message]
2025-03-31 10:57 ` Ryo Takakura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331080318.BdZQodhu@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pmladek@suse.com \
--cc=ryotkkr98@gmail.com \
--cc=samuel.holland@sifive.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®