From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69511214A88; Mon, 31 Mar 2025 14:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743432825; cv=none; b=IbY+ei+jhy9B3NuNTXKzjXbXTeIHMcjpAZfOY6G+FzIsLHa5UKZtlW/Y8+xEuH6iCdr4kvAYP/AtFKAH3ECztLzsm7xeoY7AifgtNI9RXgDWwy5EY02aN8Kr8hOv4HEQaU5uqtM+HqMNd+ibeytNrV5AB+EhIJSxpPbSEtOyOBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743432825; c=relaxed/simple; bh=uQFa8VPa77pMARASFQnw4YhBH/IrNw7QrbHmXyIPycs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oTBThPtCdjnw4+79A2A4Gt0tESNce1wWcR1ik3FJk4CCPKeZvVpbhy+H9S4jMTpRYYmIzKP9hvl8Jfaa2LnAbqtbFQd1acfSLxMEzspTeFrd7aCNEW4a6L8VjNX0S67MczVGFaQJax+FTwThvTSTvz41hvNI1H1GTyF8XMNHdJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rZFyDEzh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rZFyDEzh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADE24C4CEE3; Mon, 31 Mar 2025 14:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743432824; bh=uQFa8VPa77pMARASFQnw4YhBH/IrNw7QrbHmXyIPycs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rZFyDEzh6Z7mlO5SPtfyPPA0AuZFPDm1G8RK90jpX/TM0YzkFuXCTeDIN48rrNPTe JHuON5iKTS5JKM72f8ggCCa8WKJGJSrGzvn/gyWhbywfF1B3oKy5HRm5Dqhb62eLzT fcnmEA3lUztQmUHgZkzKP9p6SQJzc1xWo8JKOmbHjJhpARSKuf1TnlWCWiCSFVgpNx GO9GAKyJQ7zaQ7PQeQRfIRHdV62Wf8otsDrdOCrcTcSviGJkz/zpJHxVXTKSHf6bjv KE9O068Yqxevozx+rX2FcFkIB7pdi6Z7TAQsP7iO6IC4OElTSOqyOTcnBca3S2sa3z ovElbHZFHHnUw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Aakarsh Jain , Hans Verkuil , Nicolas Dufresne , Marek Szyprowski , Sasha Levin , andrzej.hajda@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 6.14 20/27] media: s5p-mfc: Corrected NV12M/NV21M plane-sizes Date: Mon, 31 Mar 2025 10:52:38 -0400 Message-Id: <20250331145245.1704714-20-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250331145245.1704714-1-sashal@kernel.org> References: <20250331145245.1704714-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14 Content-Transfer-Encoding: 8bit From: Aakarsh Jain [ Upstream commit 7d0d0b2342bebc47a46499cdf21257ed1e58c4aa ] There is a possibility of getting page fault if the overall buffer size is not aligned to 256bytes. Since MFC does read operation only and it won't corrupt the data values even if it reads the extra bytes. Corrected luma and chroma plane sizes for V4L2_PIX_FMT_NV12M and V4L2_PIX_FMT_NV21M pixel format. Suggested-by: Hans Verkuil Signed-off-by: Aakarsh Jain Reviewed-by: Nicolas Dufresne Acked-by: Marek Szyprowski Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.c index 73f7af674c01b..0c636090d723d 100644 --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.c +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.c @@ -549,8 +549,9 @@ static void s5p_mfc_enc_calc_src_size_v6(struct s5p_mfc_ctx *ctx) case V4L2_PIX_FMT_NV21M: ctx->stride[0] = ALIGN(ctx->img_width, S5P_FIMV_NV12M_HALIGN_V6); ctx->stride[1] = ALIGN(ctx->img_width, S5P_FIMV_NV12M_HALIGN_V6); - ctx->luma_size = ctx->stride[0] * ALIGN(ctx->img_height, 16); - ctx->chroma_size = ctx->stride[0] * ALIGN(ctx->img_height / 2, 16); + ctx->luma_size = ALIGN(ctx->stride[0] * ALIGN(ctx->img_height, 16), 256); + ctx->chroma_size = ALIGN(ctx->stride[0] * ALIGN(ctx->img_height / 2, 16), + 256); break; case V4L2_PIX_FMT_YUV420M: case V4L2_PIX_FMT_YVU420M: -- 2.39.5