From: Daeho Jeong <daeho43@gmail.com>
To: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>
Subject: [PATCH] f2fs-tools: apportion atomic write's total delay to its operations
Date: Mon, 31 Mar 2025 13:28:35 -0700 [thread overview]
Message-ID: <20250331202835.4057396-1-daeho43@gmail.com> (raw)
From: Daeho Jeong <daehojeong@google.com>
To utilize the delay option of atomic write more useful, need to
apportion it to each operation of it.
Signed-off-by: Daeho Jeong <daehojeong@google.com>
---
tools/f2fs_io/f2fs_io.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c
index 57a931d..292dcb3 100644
--- a/tools/f2fs_io/f2fs_io.c
+++ b/tools/f2fs_io/f2fs_io.c
@@ -769,24 +769,30 @@ static void do_write_with_advice(int argc, char **argv,
}
}
+ total_time = get_current_us();
if (atomic_commit || atomic_abort) {
int ret;
if (argc == 8)
- useconds = atoi(argv[7]) * 1000;
+ useconds = atoi(argv[7]) * 1000 / (count + 2);
+
+ if (useconds)
+ usleep(useconds);
if (replace)
ret = ioctl(fd, F2FS_IOC_START_ATOMIC_REPLACE);
else
ret = ioctl(fd, F2FS_IOC_START_ATOMIC_WRITE);
+ if (useconds)
+ usleep(useconds);
+
if (ret < 0) {
fputs("setting atomic file mode failed\n", stderr);
exit(1);
}
}
- total_time = get_current_us();
for (i = 0; i < count; i++) {
uint64_t ret;
@@ -804,10 +810,10 @@ static void do_write_with_advice(int argc, char **argv,
if (ret != buf_size)
break;
written += ret;
- }
- if (useconds)
- usleep(useconds);
+ if (useconds)
+ usleep(useconds);
+ }
if (atomic_commit) {
int ret;
--
2.49.0.472.ge94155a9ec-goog
next reply other threads:[~2025-03-31 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 20:28 Daeho Jeong [this message]
2025-04-07 2:12 ` [f2fs-dev] " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331202835.4057396-1-daeho43@gmail.com \
--to=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®