From: Greg KH <gregkh@linuxfoundation.org>
To: Erick Karanja <karanja99erick@gmail.com>
Cc: outreachy@lists.linux.dev, philipp.g.hortmann@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] staging: rtl8723bs: no space before tabs
Date: Tue, 1 Apr 2025 19:18:21 +0100 [thread overview]
Message-ID: <2025040127-unretired-veto-b056@gregkh> (raw)
In-Reply-To: <4e39b1295d68aea947aa5757e3148a2e401b72bc.1743524096.git.karanja99erick@gmail.com>
On Tue, Apr 01, 2025 at 07:59:37PM +0300, Erick Karanja wrote:
> Remove spaces before tabs to comply with the Linux kernel coding style
> guidelines. Proper indentation using tabs improves code consistency
> and readability.
>
> Reported by checkpatch:
>
> WARNING: please, no space before tabs
>
> Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/hal_btcoex.c | 33 ++++------------------
> 1 file changed, 6 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> index 9105594d2dde..44f73baf1cb4 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> @@ -9,14 +9,14 @@
> #include <hal_btcoex.h>
> #include <Mp_Precomp.h>
>
> -/* Global variables */
> +/*Global variables */
Does that look right? (hint, it isn't...)
Always put a space after the /* and before text. You removed the one
that was there already :(
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-01 18:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 16:59 [PATCH v2 0/5] Clean up patches for rtl8723bs driver Erick Karanja
2025-04-01 16:59 ` [PATCH v2 1/5] staging: rtl8723bs: use preferred comparison order Erick Karanja
2025-04-01 22:32 ` Julia Lawall
2025-04-01 16:59 ` [PATCH v2 2/5] staging: rtl8723bs: add spaces between ternary and binary operators Erick Karanja
2025-04-01 22:30 ` Julia Lawall
2025-04-01 16:59 ` [PATCH v2 3/5] staging: rtl8723bs: Rename variables Erick Karanja
2025-04-01 22:28 ` Julia Lawall
2025-04-01 16:59 ` [PATCH v2 4/5] staging: rtl8723bs: fix check lines should not end with a '(' Erick Karanja
2025-04-01 16:59 ` [PATCH v2 5/5] staging: rtl8723bs: no space before tabs Erick Karanja
2025-04-01 18:18 ` Greg KH [this message]
2025-04-01 22:25 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025040127-unretired-veto-b056@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=karanja99erick@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®