From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8D9613212A for ; Wed, 2 Apr 2025 16:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743612447; cv=none; b=MH6sSFnfp7+Id5PEOPDWwlLlSdN27mixyK3iox54wIdtO/+W4r8D+3c4FBzsDxLuTovrLyWTs9llDc45lMlJU8nE7+U8PSxgs/T4KW1rS7ku3EX5U2h6bL2DaAE+j2J3UxLhgUKEnhPdRm8NDrblvxaYqXDmj9L93std1gky/QM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743612447; c=relaxed/simple; bh=8uZrNecXdf9WMTuxk6LZlsdLmuyrTIq1kpqDpzaDdh4=; h=Date:Mime-Version:Message-ID:Subject:From:To:Content-Type; b=FxTB7vLk1x6AnBUJGmjWy55LB42cG1Wy2kfjFSe6GnceffrO7f3irpFCJF+Xtr+fSqNgTD+3f5ivfYWV2HBV2lIsF5z/4EfsL/k3D7GB5JGns7zsJ15LDDTDyjjY0q/RvgfLqEMptYhmvy/agGX85uGSjDGxiFwSMVYAdJXpxGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EsSODmUJ; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EsSODmUJ" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-73917303082so226901b3a.3 for ; Wed, 02 Apr 2025 09:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1743612445; x=1744217245; darn=vger.kernel.org; h=to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=PVnv1ifk/rRII3YKtoo3yxRHMTzfbahaxqJkJewxpwQ=; b=EsSODmUJvDQXtWXBuZ0ePbkBEmlQp4xH1iFsDDRqvYxQ7kJj/w0XNKy/xObI2yQa/g iGKS4tkMvPwljwtwaO10QJFCps7XfdyRHsEjy6GU2hKUaIBSPXKRJ90jPbp8kxTXbUoo 2JuNhvSHZtcemg7FgECUP4Vf9iyCl1Ej4Yj0zAz/B7kzlEHn8W5m1mBgIMronHebI+zL orxfytBLFyukp1oL6Qj9ueKPxy9hTJYf1KlsVXDUtQbxTtiZoUMLOQzKborkFGRnvB65 DksqQX8QlXO4+cwc3EIG7y4o9jIJCUcW9fakHJxOIN/qx5EUZq3ee3Ws9nq7B4tlYvgS lt0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743612445; x=1744217245; h=to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PVnv1ifk/rRII3YKtoo3yxRHMTzfbahaxqJkJewxpwQ=; b=BIFlk3aVrVhB8hIs+DolK4SkyZscH7Qhy6LB1MRtfzrNd4XRk/v8oAVSvbMx7VGzA3 iexOszdq6bJ4q47OgNijUgXyM8lb7xo5Hn9Zi4rOUdIK65U8Dm7Q71tGo8U8oXsUzouP Yu7z7cJl+qcRJAMbPf0CfNHQcv1KN+rrRazgMQwkBihIz93nQJ6LbYV/t3/ibZ/TLISg 2X9d5wdxbe/HrDxIXNP3sSYkJ6XBGFC4hKXkPut6CoicXuSZOBst9rsmLi5nJzziBXEH 0cp/yB+qDY7xty+nZse6RCyy+H/QmFncis8yItoOkryGE0RfDLlzRsV5oDSnhkg5YpQ6 1uCg== X-Forwarded-Encrypted: i=1; AJvYcCXZI2q5ple9aVAUUUmjVaJVLDHtZF+P9zeHLiQJCLKCnhtBEHcbpwFZEHh8jFMv4v50cGwW6CRt6HrboLU=@vger.kernel.org X-Gm-Message-State: AOJu0YxC21r5gNJmSk3vWAYOjYU9m2fJjSSEsHYApNw1rOcoYhhUaSTV Y3qDfA0FrnAKwzoJbfveLXfsc6kk8zzDhVjxXnMXfxq1wiLSh4Oq/zZdYVFWfIbWipIutnXMdQH qgvgZ9w== X-Google-Smtp-Source: AGHT+IFbMkJj9ne/OwXFL6hbxTJviKMau0ZrjEO9my5uifu4AeWO0qy/X/nYCmeUaICKAHkEaZqh7otMMDef X-Received: from pfbei43.prod.google.com ([2002:a05:6a00:80eb:b0:736:46a8:452d]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1251:b0:736:34a2:8a20 with SMTP id d2e1a72fcca58-739804356e6mr25656621b3a.21.1743612445110; Wed, 02 Apr 2025 09:47:25 -0700 (PDT) Date: Wed, 2 Apr 2025 09:47:15 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.49.0.504.g3bcea36a83-goog Message-ID: <20250402164720.3847573-1-irogers@google.com> Subject: [PATCH v2 0/5] NMI warning and debug improvements From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Howard Chu , Dominique Martinet , Levi Yun , "Dr. David Alan Gilbert" , Andi Kleen , James Clark , Weilin Wang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" The NMI warning wouldn't fire even if all the events were for one PMU type. Remove a nearby, and no longer useful, mixed hardware event group function. Improve the evlist to string function and dump it in verbose mode after the reordered events warning. As commonly happens legacy events like instructions will be uniquified to hybrid events like cpu_core/instructions/, even though the encodings differ. To make this correct either: https://lore.kernel.org/lkml/20250312211623.2495798-1-irogers@google.com/ or: https://lore.kernel.org/linux-perf-users/20250109222109.567031-1-irogers@google.com/ needs merging. v2: Rename evlist__has_hybrid to evlist__has_hybrid_pmus and add a max_length parameter to evlist__format_evsels as suggested by Kan Liang. Ian Rogers (5): perf stat: Better hybrid support for the NMI watchdog warning perf stat: Remove print_mixed_hw_group_error perf evlist: Refactor evlist__scnprintf_evsels perf evlist: Add groups to evlist__format_evsels perf parse-events: Add debug dump of evlist if reordered tools/perf/builtin-record.c | 9 ++++--- tools/perf/util/evlist.c | 34 ++++++++++++++++------- tools/perf/util/evlist.h | 3 ++- tools/perf/util/parse-events.c | 16 ++++++++--- tools/perf/util/stat-display.c | 49 +++++++++++----------------------- tools/perf/util/stat.h | 1 - 6 files changed, 60 insertions(+), 52 deletions(-) -- 2.49.0.504.g3bcea36a83-goog