mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denis Arefev <arefev@swemel.ru>
To: ilpo.jarvinen@linux.intel.com
Cc: arefev@swemel.ru, corentin.chary@gmail.com, hdegoede@redhat.com,
	linux-kernel@vger.kernel.org, luke@ljones.dev,
	lvc-project@linuxtesting.org,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] asus-laptop: Fix an uninitialized variable
Date: Thu,  3 Apr 2025 15:23:23 +0300	[thread overview]
Message-ID: <20250403122323.18129-1-arefev@swemel.ru> (raw)
In-Reply-To: <ddd60b0f-47a5-c93b-f055-d6900dfbd7de@linux.intel.com>

> But if ACPI doesn't provide a value, why should that clamp value be used 
> instead? I'd tend to think curr would be more suitable "default".
> But shouldn't the loop either use continue to retry or the function 
> return curr right away if acpi_evaluate_integer() returns an error?

Hi Ilpo.

I'm sorry it took me so long to respond.

Yes, your comments are correct.
I hope the new patch will help to make the algorithm less noisy.

Regards Denis.


      reply	other threads:[~2025-04-03 12:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25  9:57 Denis Arefev
2025-03-25 11:18 ` Ilpo Järvinen
2025-03-26 12:07   ` Arefev
2025-03-28 13:53     ` Ilpo Järvinen
2025-04-03 12:23       ` Denis Arefev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250403122323.18129-1-arefev@swemel.ru \
    --to=arefev@swemel.ru \
    --cc=corentin.chary@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=lvc-project@linuxtesting.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®