From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F04935942; Thu, 3 Apr 2025 12:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743683887; cv=none; b=JmkrrE5wzNSCrYtIGPYzkWZVSTunbIp46/G1MM/WmSOonkKciIXqCaKz4lglkCKyP+8QAwYDBPl/KM/vRRKLADtWBzqHf4y4OjuC+Dl7J/6xnDe1C4nXdAuaFwFJlEW6Q9XQtnxDI3wsRRI5kT3iNWbvN0OUetGk1hOEiRLtkVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743683887; c=relaxed/simple; bh=NLRMsVF3jqOlHjm4CeTwwI0Q/SdgdU8V4yGDILCONBU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KuWOdQK0zgjW7FT0pdoi0oTb3QcATgAlECBZx1L7tsjnap0pdydI5wwAINY4JrzNrtGOf3UUIs5dmbeNDRbBCtugV5OVJa8vz1B4XmXOJkSgjKZB5Fkk2yBMub7/UhrPQViF4qUuDdSvaAAskrUxj/5X9S76vpqtiaNopuNUL9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=m4oI2S6b; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="m4oI2S6b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743683886; x=1775219886; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NLRMsVF3jqOlHjm4CeTwwI0Q/SdgdU8V4yGDILCONBU=; b=m4oI2S6bKC5bIJTn2uEu2hPJ+4ckMfZAi0PjbUmSR8blR6MRUHhYZyFs xjB+4L04fW2lSqO2SM0Vlt4h519UDQ5QQzG3PpU0fWsjjLMWEwCGkkGuv 5DVvLXiu2V0MmOqDnqbWBZMAlJ6U4l25KBpDeakyZSQucUNS6iYbDHobV qSFOWo8wI3lbI63Sae/fIyeBQYir1dsONGqzgjAvjCDDqsVrqxbBeS4lP 4LnWkkKEeFX4m/jrhvMBVkL4wLFtDXfYw2U+nsKGHmo6g2VFoBdmSg8yu necl/bXwVsPVkgqn20NirTmD8fkzCckxGoWq3/rv+EMzoewMrkbFSNtRq Q==; X-CSE-ConnectionGUID: 09iZ9wUjTgao//Gjae3V2Q== X-CSE-MsgGUID: aRfcC/LcTZiY+JOtuYIcEw== X-IronPort-AV: E=McAfee;i="6700,10204,11393"; a="70457422" X-IronPort-AV: E=Sophos;i="6.15,184,1739865600"; d="scan'208";a="70457422" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2025 05:38:05 -0700 X-CSE-ConnectionGUID: LVx2I6BTSnKfcHKcWm5Wrw== X-CSE-MsgGUID: DXUb3WQKTHSHnRrIg+WGXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,184,1739865600"; d="scan'208";a="132205912" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa005.jf.intel.com with ESMTP; 03 Apr 2025 05:38:03 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 468CAEC; Thu, 03 Apr 2025 15:38:00 +0300 (EEST) Date: Thu, 3 Apr 2025 15:38:00 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Linus Walleij , Bartosz Golaszewski Subject: Re: [PATCH v1 4/5] gpiolib: acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup Message-ID: <20250403123800.GK3152277@black.fi.intel.com> References: <20250402122301.1517463-1-andriy.shevchenko@linux.intel.com> <20250402122301.1517463-5-andriy.shevchenko@linux.intel.com> <20250403103506.GJ3152277@black.fi.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Apr 03, 2025 at 02:04:04PM +0300, Andy Shevchenko wrote: > On Thu, Apr 03, 2025 at 01:35:06PM +0300, Mika Westerberg wrote: > > On Wed, Apr 02, 2025 at 03:21:19PM +0300, Andy Shevchenko wrote: > > > Some of the contents of struct acpi_gpio_lookup repeats what we have > > > in the struct acpi_gpio_params. Reuse the latter in the former. > > > > + struct acpi_gpio_params par; > > > > params is better name > > It's been already used elsewhere in the code. Do you want renaming there as > well for consistency's sake? If there is no problem confusing these then no need to rename anything else. > > ... > > > > struct acpi_gpio_lookup *lookup = data; > > > + struct acpi_gpio_params *par = &lookup->par; > > > > These are not changed I guess so can this be const? > > They are, see below. So the answer, it can't. Okay then nevermind.