From: Arnd Bergmann <arnd@kernel.org>
To: "Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] pwm: rcar: include linux/bitfield.h
Date: Thu, 3 Apr 2025 15:23:59 +0200 [thread overview]
Message-ID: <20250403132406.81003-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
The use of FIELD_MAX() breaks in some configurations because of
a missing header:
drivers/pwm/pwm-rcar.c:114:12: error: call to undeclared function 'FIELD_MAX'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
114 | if (tmp > FIELD_MAX(RCAR_PWMCNT_CYC0_MASK))
| ^
Fixes: edd549f4956b ("pwm: rcar: Improve register calculation")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pwm/pwm-rcar.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pwm/pwm-rcar.c b/drivers/pwm/pwm-rcar.c
index 19e5d0b849a6..578dbdd2d5a7 100644
--- a/drivers/pwm/pwm-rcar.c
+++ b/drivers/pwm/pwm-rcar.c
@@ -8,6 +8,7 @@
* - The hardware cannot generate a 0% duty cycle.
*/
+#include <linux/bitfield.h>
#include <linux/clk.h>
#include <linux/err.h>
#include <linux/io.h>
--
2.39.5
next reply other threads:[~2025-04-03 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 13:23 Arnd Bergmann [this message]
2025-04-03 14:44 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403132406.81003-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®