From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7FD924BC06 for ; Thu, 3 Apr 2025 16:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743696714; cv=none; b=cSmhYPa+7qz6svQaVtlm1+yCJqkZZpktrQMCLk/4J2WPH8FIGrdbwWPvYU1tqeUfvmdkIreojZVnmODtnoSC2jVDnUK/ToDo4EFPUZKaOBQXVKXhsAtt37jb7J/3asMbH30DNHAfaN1YUmuqndsA83uCTDeiSFJozJ+KaNML0CA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743696714; c=relaxed/simple; bh=lGyfO4gIma4Oj5qkfJ57pkYMWl5NBVmzYdOeV93jPgw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GyNV+FFt5wcMXo4Dnb9sVcA4F7GW879ZMBhbf/LLXxwgqoPsMl6hLxk67hq5KVN8m0bBcsqMenyfd5+p3pJhAkQq3Cahc2p+9pZInKDkwf/+4do206wskEw0d7rJnManr4fUxx3HbVTs6e1vUlghyyDAEgqnDtB76Yl9/5XkaPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=XMawi/yb; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="XMawi/yb" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-39c2688619bso734736f8f.1 for ; Thu, 03 Apr 2025 09:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1743696711; x=1744301511; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CbCA5EnpK3GbHkhltbHt5Uy2DViRFKY5hJRw/vEZruk=; b=XMawi/ybsbVCNXJ9Tmklux+k2OA7KtSmykmV6QkLrA4pXX/CRnTceA3QUrrhkLyM3p ubFb5PhLFRMJoR0aEz5uxS/RApAbmhf1aV4cEvYGTbI8G02BtDNWHangNdkKZSudHl8V wV+rsgkz5iPDm71x8O7SQO3DIpCmQABU5ilV+cYktldjRJipqKj6MnzGRNKbpMT/YwaE yE3WpVk2KBHzj9rwM6iBtLLd20mxMK66jJXdT8WCHs52YLskNK7veVEtWhQhxGcErKAV +T22SyqwGkkXKYQ0HUbX4qBO8IXliYwXJmijpcjDtck0kHYdQb+YabaQJfpMmWaG8CrK e3HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743696711; x=1744301511; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CbCA5EnpK3GbHkhltbHt5Uy2DViRFKY5hJRw/vEZruk=; b=PaG/7mcAQL6WTXE0VL4qfdF0uHjtN1vNeIj/M2aZJayk1Ww/QxtuGO9G/iGMiLCrVW /Mmhfi6mKcTsOYQwHS4/6c+MeYLc5XCszWaD04+InRj9s3fqmwaZDY/1phiWyy2UCwQ8 tU2/F5A+0+YoDHJHsOs95QdMwhho8JlIRDUeI0B7aT83vb1OXvdkWpJ9gQdMv/QmP4nP YFkaGyvZpyT6oV6I5sudpzushKo3n8bC05Ofoa4Tr3phNK46MuMMNeJ4NP8yHUWh4ks7 m7OWnTmBibuTSJc12dkLkb+c7nXtJSZu5IRJtYQK05xtBhQ03tJr4ooVQni45EzZ0pKz 3RFQ== X-Forwarded-Encrypted: i=1; AJvYcCXYhPqYu3uyIkNFXZWIoRymNEZLIrui50WiMIYKcpMNYhNZRuLdxIz6OMV614fphYn+CzMwZnS3bOMfl0w=@vger.kernel.org X-Gm-Message-State: AOJu0Yya5wrFHeRAqSu74CY+w+WZzQY/ybaOdHfcCilsc+T442Iyka68 FRxY3BmpiF3GFiRiXaxqWhIemk11/LGvxwz2nsFfnwI3neWXopwrNARliMSy1jk= X-Gm-Gg: ASbGncu3oIi8efsbRJs7pIY/jngvUNrWECiKTleKTmkIgkQo5rf4y+F5j0dnlFBDmI1 cUqYmCOVoaN8+j34/7ZaSah4MIf1tEOt2j8h1olVBPmQo/KJ2EH2AOPlF/WoGoauYJuIeUAgm05 mh8PYxscKhQQGaCw/6joSpyH09oxa/dOn833EOB51GquiOr6v7Im7rw27bxJISxI3YnJYFacMkb eqBaINcdoEoFwCoPtBpEeVjESHBOPTqrzNZW1MteanYreSMVjYjqwSvWONc1IvdsBeiRjKd+q/z c7U+vig+snY0mzIcMOQUOdPyOe9MA4LGQ/tVJRlmAN6Kys8rkXkhj1g2fjbY4XxqebM= X-Google-Smtp-Source: AGHT+IHk+rY+9t42v3FHXm37pqM5VS3PNMNXgS/IMHtIz8wnmpMjaYHaz+yWJEDXmcQ9h3GclT0Xag== X-Received: by 2002:a05:6000:2288:b0:39c:1f04:bb4a with SMTP id ffacd0b85a97d-39c30321ed2mr2783967f8f.10.1743696710942; Thu, 03 Apr 2025 09:11:50 -0700 (PDT) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30226acfsm2112383f8f.88.2025.04.03.09.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 09:11:50 -0700 (PDT) From: Marco Crivellari To: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Bogendoerfer , Marco Crivellari , Frederic Weisbecker , Anna-Maria Behnsen , Thomas Gleixner , Peter Zijlstra , Huacai Chen , "Maciej W . Rozycki" Subject: [PATCH v7 0/2] MIPS: Fix idle VS timer enqueue Date: Thu, 3 Apr 2025 18:11:41 +0200 Message-ID: <20250403161143.361461-1-marco.crivellari@suse.com> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch aims to fix idle routine while the CPU receive an interrupt, because __r4k_wait() only checks if TIF_NEED_RESCHED is set before going to sleep. The same behavior has been changed in LoongArch [1]. Code (cross) compiled successfully and I manage to test it on a VM emulating a malta board. I ran QEMU with: qemu-system-mips64el -M malta -m 2G -kernel vmlinux -serial stdio -drive \ file=rootfs.ext2,format=raw -append "rootwait root=/dev/sda" -cpu 5Kc rootfs generated using buildroot (malta default configuration). - [1] https://github.com/chenhuacai/linux/commit/a8aa673ea46c03b3f62992ffa4ffe810ac84f6e3 --- Changes in v7: - patch 2 to handle __r4k_wait() moved to .cpuidle.text section - removed .noreorder section from __r4k_wait() - idle region of 32-bytes - removed C wrapper r4k_wait() and renamed __r4k_wait() to r4k_wait() - changes discussed in: https://lore.kernel.org/lkml/20250315194002.13778-1-marco.crivellari@suse.com/T/#m07f2568d9099101637063bd057a497ceb846be3d Changes in v6: - typo in comment, capitalise sentences and full stops Changes in v5: - comment: idle interrupt region, instead of rollback region Changes in v4: - comments: 36 byte region Changes in v3: - changed "daddiu k0, 1" with PTR_ADDIU k0, 5 - replaced CONFIG_CPU_MICROMIPS with 3 _ssnop followed by _ehb - integrated the commit message with explanation about CONFIG_CPU_MICROMIPS replacement Changes in v2: - Changes introduced by Huacai: https://lore.kernel.org/linux-mips/20250214105047.150835-1-marco.crivellari@suse.com/T/#m75d9c587829e15e0d7baec13078be4e65c936408 Marco Crivellari (2): MIPS: Fix idle VS timer enqueue MIPS: Move __r4k_wait() to .cpuidle.text section arch/mips/include/asm/idle.h | 3 +- arch/mips/kernel/genex.S | 63 +++++++++++++++++++++--------------- arch/mips/kernel/idle.c | 7 ---- 3 files changed, 38 insertions(+), 35 deletions(-) -- 2.49.0