From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E30425F79F; Thu, 3 Apr 2025 19:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743707058; cv=none; b=sFLXTGnuthnnfOnkLbz9lX4iSKK0Rls4jA6n6vx+q/bki3rfcQ590niEDKTAX2QjPKPegBckbfwHkX3TK5ufKADjxqZf2ZTylNJyKbU4GWBbwM4N8O0AD1/5MaNl330lsi/t8YqCUbPKF5JtPIIJ94YEZ30gI23wpLLLGyj5YOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743707058; c=relaxed/simple; bh=h6gEOvJDv34HYKXsMSuwpbVEHLjPxh7/tkY5Otm+ikw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SXsuTDFT3UbtDbRV8ZNW0FFY2IuB9ou7n8wZzGx/m5qj5pGehAiVfodXtqalkFQFFN1db1sqWwGan4/n0PhjZklACyxzAjuej3FUsxlP6cCbhqXnfyzXrXRxSkhvztyhdjaE5BMYG30NKQRb4IHndBdq8Y2nvmxijTFUzRLFetA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m7POJJEn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m7POJJEn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE134C4CEE9; Thu, 3 Apr 2025 19:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743707056; bh=h6gEOvJDv34HYKXsMSuwpbVEHLjPxh7/tkY5Otm+ikw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m7POJJEnvEvhiA5KcJHi2m+HEFbKK8XwJIR1BrBn956egCurh8UMZJ/KVf8Kea6fJ QBF8aqrtPgJR9NW8zzNeZmu6yWBvJijQFKHEEEtb0LEbS6qEEkswXPenbFPxN1fs48 YNLnytXj1hD4HkZlN5keHzwKk2AokoUR1Cmz+6OCWEh3dREZRxtG95fC7+QYcO+huy mHZGuz8hOw5HnSFxVYslx6ViKgSM3Y4LYOI5RhY8Q1uv965V9ud+jVgq6GZj0TuK// O1iR5YvEut5uOuLi8jae/yFbqkd1MosHSeoHDu9yoAmdp46QTMDQuwY18ms25jstKd hDmD5HYpjUdcQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: P Praneesh , Jeff Johnson , Sasha Levin , jjohnson@kernel.org, ath12k@lists.infradead.org Subject: [PATCH AUTOSEL 6.13 04/49] wifi: ath12k: Fix invalid entry fetch in ath12k_dp_mon_srng_process Date: Thu, 3 Apr 2025 15:03:23 -0400 Message-Id: <20250403190408.2676344-4-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250403190408.2676344-1-sashal@kernel.org> References: <20250403190408.2676344-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.13.9 Content-Transfer-Encoding: 8bit From: P Praneesh [ Upstream commit 63fdc4509bcf483e79548de6bc08bf3c8e504bb3 ] Currently, ath12k_dp_mon_srng_process uses ath12k_hal_srng_src_get_next_entry to fetch the next entry from the destination ring. This is incorrect because ath12k_hal_srng_src_get_next_entry is intended for source rings, not destination rings. This leads to invalid entry fetches, causing potential data corruption or crashes due to accessing incorrect memory locations. This happens because the source ring and destination ring have different handling mechanisms and using the wrong function results in incorrect pointer arithmetic and ring management. To fix this issue, replace the call to ath12k_hal_srng_src_get_next_entry with ath12k_hal_srng_dst_get_next_entry in ath12k_dp_mon_srng_process. This ensures that the correct function is used for fetching entries from the destination ring, preventing invalid memory accesses. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 Tested-on: WCN7850 hw2.0 WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Signed-off-by: P Praneesh Link: https://patch.msgid.link/20241223060132.3506372-7-quic_ppranees@quicinc.com Signed-off-by: Jeff Johnson Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath12k/dp_mon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath12k/dp_mon.c b/drivers/net/wireless/ath/ath12k/dp_mon.c index 494984133a919..a168640c27625 100644 --- a/drivers/net/wireless/ath/ath12k/dp_mon.c +++ b/drivers/net/wireless/ath/ath12k/dp_mon.c @@ -2545,7 +2545,7 @@ int ath12k_dp_mon_rx_process_stats(struct ath12k *ar, int mac_id, dest_idx = 0; move_next: ath12k_dp_mon_buf_replenish(ab, buf_ring, 1); - ath12k_hal_srng_src_get_next_entry(ab, srng); + ath12k_hal_srng_dst_get_next_entry(ab, srng); num_buffs_reaped++; } -- 2.39.5