From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FF34292145; Thu, 3 Apr 2025 19:14:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743707650; cv=none; b=Cdpldm4AFuYyL0pSkEYLw/ql75bhaC1tqlfDREYH8WxbtxqusOu/8Js6MmNksJvYOhjwRr8x3mbXOW1nYeJapmCvS1qyd/LeAoT3DP2Yn8TI6vuE7C8C3MEKReKI6VhdU6w0Xn9WKZ+dCyYhNTNYqvKwb2Znr12E54q1rHNLLK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743707650; c=relaxed/simple; bh=WRSh9wZ4UfhlkSw5qvrf+JFaAIN577vL3T1ibosA4q4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Xonz8YfvNaZwGnExUVo6+55AUS9c3qEP6jRS4wjVovFK9oWZ32fs3DOGgKUo+ZLRiB6wO1XmTSv7cKiqvVv35uZe8shXaEY9ivDBHR6LamttfajdzWh8DK+HzRAASSrpaj7n89YCZppwCKChRypWwk8K1By4qgJvaV/HjjOkhmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n8xtQbUp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n8xtQbUp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B561EC4CEE8; Thu, 3 Apr 2025 19:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743707649; bh=WRSh9wZ4UfhlkSw5qvrf+JFaAIN577vL3T1ibosA4q4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n8xtQbUpNLQMqvHQJGHAzm6UR+37niGO7RG+qq0dsAWFdhGsxPnJ2m9wdTDUWwWKf uYlEak3OLM87+8azAoEB0CXF4zO5rM57OQ0egAwfKANQA/o5PKRxApj4brAIBjrQjV PhEdu4h3ZewHLvXQA6EPKyXbEL9PRwFJJVj6yVHwgjuQ8qZemhqPNWbOVnYOsozssY oLsPPRXCOROuIK5Sl7fRIP3nrdx07rM8uNgegLlQhC3GDzTBU+bgF8VQFZH/zXFLpB NXu3ZahII4Tb7jC88GfMclXxO/ZJbgy49jvsTB0gXEFV31KvJrx3mSdKXxyy7jZ71s itDKOt+vdrLGA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Luca Ceresoli , Dmitry Baryshkov , Robert Foss , Sasha Levin , neil.armstrong@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.14 18/44] drm/bridge: panel: forbid initializing a panel with unknown connector type Date: Thu, 3 Apr 2025 15:12:47 -0400 Message-Id: <20250403191313.2679091-18-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250403191313.2679091-1-sashal@kernel.org> References: <20250403191313.2679091-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14 Content-Transfer-Encoding: 8bit From: Luca Ceresoli [ Upstream commit b296955b3a740ecc8b3b08e34fd64f1ceabb8fb4 ] Having an DRM_MODE_CONNECTOR_Unknown connector type is considered bad, and drm_panel_bridge_add_typed() and derivatives are deprecated for this. drm_panel_init() won't prevent initializing a panel with a DRM_MODE_CONNECTOR_Unknown connector type. Luckily there are no in-tree users doing it, so take this as an opportinuty to document a valid connector type must be passed. Returning an error if this rule is violated is not possible because drm_panel_init() is a void function. Add at least a warning to make any violations noticeable, especially to non-upstream drivers. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Ceresoli Signed-off-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/20250214-drm-assorted-cleanups-v7-5-88ca5827d7af@bootlin.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/drm_panel.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c index 9940e96d35e30..c627e42a7ce70 100644 --- a/drivers/gpu/drm/drm_panel.c +++ b/drivers/gpu/drm/drm_panel.c @@ -50,7 +50,7 @@ static LIST_HEAD(panel_list); * @dev: parent device of the panel * @funcs: panel operations * @connector_type: the connector type (DRM_MODE_CONNECTOR_*) corresponding to - * the panel interface + * the panel interface (must NOT be DRM_MODE_CONNECTOR_Unknown) * * Initialize the panel structure for subsequent registration with * drm_panel_add(). @@ -58,6 +58,9 @@ static LIST_HEAD(panel_list); void drm_panel_init(struct drm_panel *panel, struct device *dev, const struct drm_panel_funcs *funcs, int connector_type) { + if (connector_type == DRM_MODE_CONNECTOR_Unknown) + DRM_WARN("%s: %s: a valid connector type is required!\n", __func__, dev_name(dev)); + INIT_LIST_HEAD(&panel->list); INIT_LIST_HEAD(&panel->followers); mutex_init(&panel->follower_lock); -- 2.39.5