From: Werner Sembach <wse@tuxedocomputers.com>
To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, bentiss@kernel.org
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Werner Sembach <wse@tuxedocomputers.com>
Subject: [PATCH v6 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices
Date: Thu, 3 Apr 2025 23:02:08 +0200 [thread overview]
Message-ID: <20250403212934.561943-1-wse@tuxedocomputers.com> (raw)
Next version and hopefully the final one? Lets see ^^.
I integrated more coding style suggestions from Ilpo he gave me on a different
patch, but were applicable here too.
For the why I named the subfolder nb04 and some functions *wmi_xx* see this:
https://gitlab.com/tuxedocomputers/development/packages/linux/-/tree/tuxedo-drivers_upstream_wip/drivers/platform/x86/tuxedo?ref_type=heads
- We have several ODMs identified in the board_vendor dmi string (NB01, NB02,
NB04, and NB05) and are planing to upstream drivers for all of them. So I
already incorporated it in the folder and module name.
- On NB04 devices there is a wmi_ab interface for the keyboard and a wmi_bs
interface for power control and some device informations. Util functions that
will eventually be used in both drivers are named *wmi_xx*
I also hope it was ok that I significantly cut down the cc list that was ever
expanding since v1.
v2: Integrated Armins feedback and fixed kernel test robot warnings.
v3: Fixed borked subject line of v2.
v4: Remove unrequired WMI mutex.
Move device checking from probe to init.
Fix device checking working exactly reverse as it should.
Fix null pointer dereference because,
hdev->driver_data != hdev->dev.driver_data.
v5: Move everything to subfolder nb04 in preparation for the eventual
upstreaming of other tuxedo-driver parts.
Integrated Ilpos coding style feedback.
Use dev_set/get_drvdata() based on Armins feedback.
v6: Integrated more of Ilpo coding style feedback from a different LKML
patch-thread (less files, local functions prefixed with a short string).
Werner Sembach (1):
platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices
MAINTAINERS | 6 +
drivers/platform/x86/Kconfig | 2 +
drivers/platform/x86/Makefile | 3 +
drivers/platform/x86/tuxedo/Kconfig | 8 +
drivers/platform/x86/tuxedo/Makefile | 8 +
drivers/platform/x86/tuxedo/nb04/Kconfig | 15 +
drivers/platform/x86/tuxedo/nb04/Makefile | 10 +
drivers/platform/x86/tuxedo/nb04/wmi_ab.c | 847 ++++++++++++++++++++
drivers/platform/x86/tuxedo/nb04/wmi_util.c | 95 +++
drivers/platform/x86/tuxedo/nb04/wmi_util.h | 109 +++
10 files changed, 1103 insertions(+)
create mode 100644 drivers/platform/x86/tuxedo/Kconfig
create mode 100644 drivers/platform/x86/tuxedo/Makefile
create mode 100644 drivers/platform/x86/tuxedo/nb04/Kconfig
create mode 100644 drivers/platform/x86/tuxedo/nb04/Makefile
create mode 100644 drivers/platform/x86/tuxedo/nb04/wmi_ab.c
create mode 100644 drivers/platform/x86/tuxedo/nb04/wmi_util.c
create mode 100644 drivers/platform/x86/tuxedo/nb04/wmi_util.h
--
2.43.0
next reply other threads:[~2025-04-03 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 21:02 Werner Sembach [this message]
2025-04-03 21:02 ` [PATCH v6 1/1] " Werner Sembach
2025-04-11 13:48 ` Ilpo Järvinen
2025-04-15 16:44 ` Werner Sembach
2025-04-15 17:32 ` Ilpo Järvinen
2025-04-16 12:59 ` Werner Sembach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403212934.561943-1-wse@tuxedocomputers.com \
--to=wse@tuxedocomputers.com \
--cc=bentiss@kernel.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®