From: Jerome Brunet <jbrunet@baylibre.com>
To: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Jon Mason" <jdmason@kudzu.us>,
"Dave Jiang" <dave.jiang@intel.com>,
"Allen Hubbe" <allenbh@gmail.com>
Cc: Marek Vasut <marek.vasut+renesas@gmail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Yuya Hamamachi <yuya.hamamachi.sx@renesas.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
ntb@lists.linux.dev, Jerome Brunet <jbrunet@baylibre.com>
Subject: [PATCH v2 0/3] PCI: endpoint: space allocation fixups
Date: Fri, 04 Apr 2025 19:46:19 +0200 [thread overview]
Message-ID: <20250404-pci-ep-size-alignment-v2-0-c3a0db4cfc57@baylibre.com> (raw)
This patchset fixes problems while trying to allocate space for PCI
endpoint function.
The problems, and related fixups, have been found while trying to link two
renesas rcar-gen4 r8a779f0-spider devices with the vNTB endpoint
function. This platform has 2 configurable BAR0 and BAR2, with an alignment
of 1MB, and fairly small fixed BAR4 of 256B.
This was tested with
* BAR0 (1MB): CTRL+SPAD
* BAR2 (1MB): MW0
* BAR4 (256B): Doorbell
This setup is currently not supported by the vNTB EP driver and requires a
small hack. I'm working on that too.
Changes in v2:
- Allocate space that match the iATU alignment requirement, as previously
done.
- Chose not to add a new member in struct pci_epf_bar, as initially
discussed. After reworking the code, that did not seem necessary.
- Make sure SPAD registers are 4 bytes aligned in the vNTB endpoint function
- Link to v1: https://lore.kernel.org/r/20250328-pci-ep-size-alignment-v1-0-ee5b78b15a9a@baylibre.com
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
Jerome Brunet (3):
PCI: endpoint: add epc_feature argument for pci_epf_free_space()
PCI: endpoint: improve fixed_size bar handling when allocating space
PCI: endpoint: pci-epf-vntb: simplify ctrl/spad space allocation
drivers/pci/endpoint/functions/pci-epf-ntb.c | 3 +-
drivers/pci/endpoint/functions/pci-epf-test.c | 2 ++
drivers/pci/endpoint/functions/pci-epf-vntb.c | 42 ++++++++++-----------------
drivers/pci/endpoint/pci-epf-core.c | 27 ++++++++++++-----
include/linux/pci-epf.h | 1 +
5 files changed, 40 insertions(+), 35 deletions(-)
---
base-commit: dea140198b846f7432d78566b7b0b83979c72c2b
change-id: 20250328-pci-ep-size-alignment-9d85b28b8050
Best regards,
--
Jerome
next reply other threads:[~2025-04-04 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 17:46 Jerome Brunet [this message]
2025-04-04 17:46 ` [PATCH v2 1/3] PCI: endpoint: add epc_feature argument for pci_epf_free_space() Jerome Brunet
2025-04-05 17:38 ` kernel test robot
2025-04-05 20:02 ` kernel test robot
2025-04-04 17:46 ` [PATCH v2 2/3] PCI: endpoint: improve fixed_size bar handling when allocating space Jerome Brunet
2025-04-04 17:46 ` [PATCH v2 3/3] PCI: endpoint: pci-epf-vntb: simplify ctrl/spad space allocation Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404-pci-ep-size-alignment-v2-0-c3a0db4cfc57@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=ntb@lists.linux.dev \
--cc=yoshihiro.shimoda.uh@renesas.com \
--cc=yuya.hamamachi.sx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®