From: Jens Wiklander <jens.wiklander@linaro.org>
To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
op-tee@lists.trustedfirmware.org,
linux-arm-kernel@lists.infradead.org
Cc: "Olivier Masse" <olivier.masse@nxp.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Yong Wu" <yong.wu@mediatek.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Brian Starkey" <Brian.Starkey@arm.com>,
"John Stultz" <jstultz@google.com>,
"T . J . Mercier" <tjmercier@google.com>,
"Christian König" <christian.koenig@amd.com>,
"Sumit Garg" <sumit.garg@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
azarrabi@qti.qualcomm.com,
"Simona Vetter" <simona.vetter@ffwll.ch>,
"Daniel Stone" <daniel@fooishbar.org>,
"Jens Wiklander" <jens.wiklander@linaro.org>
Subject: [PATCH v7 08/11] tee: add tee_shm_alloc_cma_phys_mem()
Date: Fri, 4 Apr 2025 16:31:31 +0200 [thread overview]
Message-ID: <20250404143215.2281034-9-jens.wiklander@linaro.org> (raw)
In-Reply-To: <20250404143215.2281034-1-jens.wiklander@linaro.org>
Add tee_shm_alloc_cma_phys_mem() to allocate a physical memory using
from the default CMA pool. The memory is represented by a tee_shm object
using the new flag TEE_SHM_CMA_BUF to identify it as physical memory
from CMA.
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
---
drivers/tee/Kconfig | 5 ++++
drivers/tee/tee_shm.c | 55 ++++++++++++++++++++++++++++++++++++++--
include/linux/tee_core.h | 4 +++
3 files changed, 62 insertions(+), 2 deletions(-)
diff --git a/drivers/tee/Kconfig b/drivers/tee/Kconfig
index 084bd794374d..53514cccd1c9 100644
--- a/drivers/tee/Kconfig
+++ b/drivers/tee/Kconfig
@@ -16,6 +16,11 @@ config TEE_DMABUF_HEAP
depends on TEE = y && DMABUF_HEAPS
default y
+config TEE_CMA
+ bool
+ depends on TEE = y && CMA
+ default y
+
if TEE
source "drivers/tee/optee/Kconfig"
diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c
index e1ed52ee0a16..d6b310b4a5fc 100644
--- a/drivers/tee/tee_shm.c
+++ b/drivers/tee/tee_shm.c
@@ -3,8 +3,11 @@
* Copyright (c) 2015-2017, 2019-2021 Linaro Limited
*/
#include <linux/anon_inodes.h>
+#include <linux/cma.h>
#include <linux/device.h>
#include <linux/dma-buf.h>
+#include <linux/dma-map-ops.h>
+#include <linux/highmem.h>
#include <linux/idr.h>
#include <linux/io.h>
#include <linux/mm.h>
@@ -13,7 +16,6 @@
#include <linux/tee_core.h>
#include <linux/uaccess.h>
#include <linux/uio.h>
-#include <linux/highmem.h>
#include "tee_private.h"
static void shm_put_kernel_pages(struct page **pages, size_t page_count)
@@ -49,7 +51,14 @@ static void tee_shm_release(struct tee_device *teedev, struct tee_shm *shm)
struct tee_shm *parent_shm = NULL;
void *p = shm;
- if (shm->flags & TEE_SHM_DMA_BUF) {
+ if (shm->flags & TEE_SHM_CMA_BUF) {
+#if IS_ENABLED(CONFIG_TEE_CMA)
+ struct page *page = phys_to_page(shm->paddr);
+ struct cma *cma = dev_get_cma_area(&shm->ctx->teedev->dev);
+
+ cma_release(cma, page, shm->size / PAGE_SIZE);
+#endif
+ } else if (shm->flags & TEE_SHM_DMA_BUF) {
struct tee_shm_dmabuf_ref *ref;
ref = container_of(shm, struct tee_shm_dmabuf_ref, shm);
@@ -306,6 +315,48 @@ struct tee_shm *tee_shm_alloc_priv_buf(struct tee_context *ctx, size_t size)
}
EXPORT_SYMBOL_GPL(tee_shm_alloc_priv_buf);
+struct tee_shm *tee_shm_alloc_cma_phys_mem(struct tee_context *ctx,
+ size_t page_count, size_t align)
+{
+#if IS_ENABLED(CONFIG_TEE_CMA)
+ struct tee_device *teedev = ctx->teedev;
+ struct cma *cma = dev_get_cma_area(&teedev->dev);
+ struct tee_shm *shm;
+ struct page *page;
+
+ if (!tee_device_get(teedev))
+ return ERR_PTR(-EINVAL);
+
+ page = cma_alloc(cma, page_count, align, true/*no_warn*/);
+ if (!page)
+ goto err_put_teedev;
+
+ shm = kzalloc(sizeof(*shm), GFP_KERNEL);
+ if (!shm)
+ goto err_cma_crelease;
+
+ refcount_set(&shm->refcount, 1);
+ shm->ctx = ctx;
+ shm->paddr = page_to_phys(page);
+ shm->size = page_count * PAGE_SIZE;
+ shm->flags = TEE_SHM_CMA_BUF;
+
+ teedev_ctx_get(ctx);
+
+ return shm;
+
+err_cma_crelease:
+ cma_release(cma, page, page_count);
+err_put_teedev:
+ tee_device_put(teedev);
+
+ return ERR_PTR(-ENOMEM);
+#else
+ return ERR_PTR(-EINVAL);
+#endif
+}
+EXPORT_SYMBOL_GPL(tee_shm_alloc_cma_phys_mem);
+
int tee_dyn_shm_alloc_helper(struct tee_shm *shm, size_t size, size_t align,
int (*shm_register)(struct tee_context *ctx,
struct tee_shm *shm,
diff --git a/include/linux/tee_core.h b/include/linux/tee_core.h
index 02c07f661349..3a4e1b00fcc7 100644
--- a/include/linux/tee_core.h
+++ b/include/linux/tee_core.h
@@ -29,6 +29,7 @@
#define TEE_SHM_POOL BIT(2) /* Memory allocated from pool */
#define TEE_SHM_PRIV BIT(3) /* Memory private to TEE driver */
#define TEE_SHM_DMA_BUF BIT(4) /* Memory with dma-buf handle */
+#define TEE_SHM_CMA_BUF BIT(5) /* CMA allocated memory */
#define TEE_DEVICE_FLAG_REGISTERED 0x1
#define TEE_MAX_DEV_NAME_LEN 32
@@ -310,6 +311,9 @@ void *tee_get_drvdata(struct tee_device *teedev);
*/
struct tee_shm *tee_shm_alloc_priv_buf(struct tee_context *ctx, size_t size);
+struct tee_shm *tee_shm_alloc_cma_phys_mem(struct tee_context *ctx,
+ size_t page_count, size_t align);
+
int tee_dyn_shm_alloc_helper(struct tee_shm *shm, size_t size, size_t align,
int (*shm_register)(struct tee_context *ctx,
struct tee_shm *shm,
--
2.43.0
next prev parent reply other threads:[~2025-04-04 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 14:31 [PATCH v7 00/11] TEE subsystem for protected dma-buf allocations Jens Wiklander
2025-04-04 14:31 ` [PATCH v7 01/11] tee: tee_device_alloc(): copy dma_mask from parent device Jens Wiklander
2025-04-04 14:31 ` [PATCH v7 02/11] optee: pass parent device to tee_device_alloc() Jens Wiklander
2025-04-04 14:31 ` [PATCH v7 03/11] optee: account for direction while converting parameters Jens Wiklander
2025-04-04 14:31 ` [PATCH v7 04/11] optee: sync secure world ABI headers Jens Wiklander
2025-04-25 13:36 ` Rouven Czerwinski
2025-04-28 8:14 ` Jens Wiklander
2025-04-04 14:31 ` [PATCH v7 05/11] tee: implement protected DMA-heap Jens Wiklander
2025-04-04 14:31 ` [PATCH v7 06/11] tee: refactor params_from_user() Jens Wiklander
2025-04-04 14:31 ` [PATCH v7 07/11] tee: new ioctl to a register tee_shm from a dmabuf file descriptor Jens Wiklander
2025-04-04 14:31 ` Jens Wiklander [this message]
2025-04-04 14:31 ` [PATCH v7 09/11] optee: support protected memory allocation Jens Wiklander
2025-04-04 14:31 ` [PATCH v7 10/11] optee: FF-A: dynamic " Jens Wiklander
2025-04-04 14:31 ` [PATCH v7 11/11] optee: smc abi: " Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404143215.2281034-9-jens.wiklander@linaro.org \
--to=jens.wiklander@linaro.org \
--cc=Brian.Starkey@arm.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=azarrabi@qti.qualcomm.com \
--cc=benjamin.gaignard@collabora.com \
--cc=christian.koenig@amd.com \
--cc=daniel@fooishbar.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jstultz@google.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=olivier.masse@nxp.com \
--cc=op-tee@lists.trustedfirmware.org \
--cc=simona.vetter@ffwll.ch \
--cc=sumit.garg@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=tjmercier@google.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®