From: Sunny Patel <nueralspacetech@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Sunny Patel <nueralspacetech@gmail.com>
Subject: [PATCH] media: i2c: ov13858: Enable clock frequency macro
Date: Sun, 6 Apr 2025 20:13:22 +0530 [thread overview]
Message-ID: <20250406144322.88464-1-nueralspacetech@gmail.com> (raw)
Defines a macro `OV13858_MCLK` for the clock frequency (19200000 Hz).
Replaces the hardcoded clock frequency value in the probe function.
Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
---
drivers/media/i2c/ov13858.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c
index 7a3fc1d28514..a1242a90cdc9 100644
--- a/drivers/media/i2c/ov13858.c
+++ b/drivers/media/i2c/ov13858.c
@@ -21,6 +21,8 @@
#define OV13858_REG_SOFTWARE_RST 0x0103
#define OV13858_SOFTWARE_RST 0x01
+#define OV13858_MCLK 19200000
+
/* PLL1 generates PCLK and MIPI_PHY_CLK */
#define OV13858_REG_PLL1_CTRL_0 0x0300
#define OV13858_REG_PLL1_CTRL_1 0x0301
@@ -1664,7 +1666,7 @@ static int ov13858_probe(struct i2c_client *client)
u32 val = 0;
device_property_read_u32(&client->dev, "clock-frequency", &val);
- if (val != 19200000)
+ if (val != OV13858_MCLK)
return -EINVAL;
ov13858 = devm_kzalloc(&client->dev, sizeof(*ov13858), GFP_KERNEL);
--
2.43.0
next reply other threads:[~2025-04-06 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-06 14:43 Sunny Patel [this message]
2025-04-15 12:03 ` Sakari Ailus
2025-04-23 14:49 ` Sunny Patel
2025-04-23 14:53 ` [PATCH V2] media: i2c: ov13858: Define macro for EXTCLK frequency Sunny Patel
2025-04-23 15:02 ` [PATCH] media: i2c: ov13858: Enable clock frequency macro Sunny Patel
2025-04-25 3:07 ` Sunny Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250406144322.88464-1-nueralspacetech@gmail.com \
--to=nueralspacetech@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®