From: Andrew Morton <akpm@linux-foundation.org>
To: Lance Yang <ioworker0@gmail.com>
Cc: will@kernel.org, peterz@infradead.org, mingo@redhat.com,
longman@redhat.com, mhiramat@kernel.org,
anna.schumaker@oracle.com, boqun.feng@gmail.com,
joel.granados@kernel.org, kent.overstreet@linux.dev,
leonylgao@tencent.com, linux-kernel@vger.kernel.org,
rostedt@goodmis.org, senozhatsky@chromium.org,
tfiga@chromium.org, amaindex@outlook.com, jstultz@google.com,
Mingzhe Yang <mingzhe.yang@ly.com>
Subject: Re: [PATCH v4 2/3] hung_task: show the blocker task if the task is hung on semaphore
Date: Mon, 7 Apr 2025 13:08:45 -0700 [thread overview]
Message-ID: <20250407130845.3c3501a03963f1d44835c755@linux-foundation.org> (raw)
In-Reply-To: <20250320064923.24000-3-ioworker0@gmail.com>
On Thu, 20 Mar 2025 14:49:22 +0800 Lance Yang <ioworker0@gmail.com> wrote:
> --- a/kernel/locking/semaphore.c
> +++ b/kernel/locking/semaphore.c
> @@ -33,12 +33,14 @@
> #include <linux/spinlock.h>
> #include <linux/ftrace.h>
> #include <trace/events/lock.h>
> +#include <linux/hung_task.h>
>
> static noinline void __down(struct semaphore *sem);
> static noinline int __down_interruptible(struct semaphore *sem);
> static noinline int __down_killable(struct semaphore *sem);
> static noinline int __down_timeout(struct semaphore *sem, long timeout);
> static noinline void __up(struct semaphore *sem);
> +static inline void __sem_acquire(struct semaphore *sem);
It feels Just Weird to forward declare a static inline. Is there a
special reason for doing this?
next prev parent reply other threads:[~2025-04-07 20:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 6:49 [PATCH v4 0/3] hung_task: extend blocking task stacktrace dump to semaphore Lance Yang
2025-03-20 6:49 ` [PATCH v4 1/3] hung_task: replace blocker_mutex with encoded blocker Lance Yang
2025-04-07 20:08 ` Andrew Morton
2025-04-08 12:29 ` Lance Yang
2025-03-20 6:49 ` [PATCH v4 2/3] hung_task: show the blocker task if the task is hung on semaphore Lance Yang
2025-04-07 20:08 ` Andrew Morton
2025-04-07 20:08 ` Andrew Morton [this message]
2025-04-08 12:27 ` Lance Yang
2025-03-20 6:49 ` [PATCH v4 3/3] samples: extend hung_task detector test with semaphore support Lance Yang
2025-04-07 20:08 ` [PATCH v4 0/3] hung_task: extend blocking task stacktrace dump to semaphore Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407130845.3c3501a03963f1d44835c755@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=amaindex@outlook.com \
--cc=anna.schumaker@oracle.com \
--cc=boqun.feng@gmail.com \
--cc=ioworker0@gmail.com \
--cc=joel.granados@kernel.org \
--cc=jstultz@google.com \
--cc=kent.overstreet@linux.dev \
--cc=leonylgao@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mingzhe.yang@ly.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®