From: Jason Gunthorpe <jgg@nvidia.com>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: benve@cisco.com, neescoba@cisco.com, leon@kernel.org,
liyuyu6@huawei.com, roland@purestorage.com, umalhi@cisco.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
yanjun.zhu@linux.dev
Subject: Re: [PATCH v2 -next] RDMA/usnic: Fix passing zero to PTR_ERR in usnic_ib_pci_probe()
Date: Mon, 7 Apr 2025 15:09:17 -0300 [thread overview]
Message-ID: <20250407180917.GA1761465@nvidia.com> (raw)
In-Reply-To: <20250324123132.2392077-1-yuehaibing@huawei.com>
On Mon, Mar 24, 2025 at 08:31:32PM +0800, Yue Haibing wrote:
> drivers/infiniband/hw/usnic/usnic_ib_main.c:590
> usnic_ib_pci_probe() warn: passing zero to 'PTR_ERR'
>
> Make usnic_ib_device_add() return NULL on fail path, also remove
> useless NULL check for usnic_ib_discover_pf()
>
> Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver")
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> v2: remove useless null check for usnic_ib_discover_pf
> ---
> drivers/infiniband/hw/usnic/usnic_ib_main.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2025-04-07 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 12:31 Yue Haibing
2025-03-25 13:55 ` Jason Gunthorpe
2025-04-07 18:09 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407180917.GA1761465@nvidia.com \
--to=jgg@nvidia.com \
--cc=benve@cisco.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=liyuyu6@huawei.com \
--cc=neescoba@cisco.com \
--cc=roland@purestorage.com \
--cc=umalhi@cisco.com \
--cc=yanjun.zhu@linux.dev \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®