From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C9F32690D2; Mon, 7 Apr 2025 18:15:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744049711; cv=none; b=YTgqN33JMIxJmZZroNaFYeeLO7u5uT2ydJVQ/vab/f80zTsHZJ6swShmfXfmKMgCqofawzYkm396NqvD+n59gxqBrzrbWXggQZWN1+jWZYAFmaQzRbr8aQaq3cVEDEGF8DOIKTBTF08MFBjO4XgvQHdCFTb0QenjV2c0T5JF7g4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744049711; c=relaxed/simple; bh=BqwADeEfMWfpSkpxZMIQF0p+lwUStPOVIOotEJAZ330=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nXHYLxyC89i84T4I4FEJxD0nXwIWzxPTMPHe4SiZwoSS+GOApXz9EnZpT9RJMZYHK85a/ePDnY1f+ObUg26nF52kR4gLREe2TtdewduVJwizXLdgY9OBePSzs/HpfRNEVuLBI4hmpN0wS+O/bt55twQaxUoEpoplMG3JASjooPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KZbTSxkQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KZbTSxkQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B922CC4CEDD; Mon, 7 Apr 2025 18:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744049710; bh=BqwADeEfMWfpSkpxZMIQF0p+lwUStPOVIOotEJAZ330=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KZbTSxkQ1RXrMZJOsttA4w3ql4MOT02dQwDN3XcCgZ4Pm4RENxoRce10oPLJ0HxW6 S1t+qRjYCGaZlQOGa7ynC11uy1r5Lff2zr9E+m6JpLGKx9ufPnF7Gp+iECr2YNgBLR g4xcag58E4l70MFQbxzD9roM8FqlJpbsgaCsF0YmMvBeiG02z0akJkz45yl/J/yUE0 D2DV7TqHne7oPtWMLI4b1Ll1UZRA8+4jMAbhJCKuGvda8j3h1XPdaz8NtKhVzIe4TV 9MGVwyi0iSguFepx3ftvUOSWWmlxmlbRPxREBUyZlYRI0B5xvxEOgAJDeKlka++4d/ qtgEJSD4k2uZQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Josh Poimboeuf , Ingo Molnar , kernel test robot , Linus Torvalds , Sasha Levin , peterz@infradead.org Subject: [PATCH AUTOSEL 6.1 11/13] objtool: Silence more KCOV warnings Date: Mon, 7 Apr 2025 14:14:45 -0400 Message-Id: <20250407181449.3183687-11-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250407181449.3183687-1-sashal@kernel.org> References: <20250407181449.3183687-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.133 Content-Transfer-Encoding: 8bit From: Josh Poimboeuf [ Upstream commit 6b023c7842048c4bbeede802f3cf36b96c7a8b25 ] In the past there were issues with KCOV triggering unreachable instruction warnings, which is why unreachable warnings are now disabled with CONFIG_KCOV. Now some new KCOV warnings are showing up with GCC 14: vmlinux.o: warning: objtool: cpuset_write_resmask() falls through to next function cpuset_update_active_cpus.cold() drivers/usb/core/driver.o: error: objtool: usb_deregister() falls through to next function usb_match_device() sound/soc/codecs/snd-soc-wcd934x.o: warning: objtool: .text.wcd934x_slim_irq_handler: unexpected end of section All are caused by GCC KCOV not finishing an optimization, leaving behind a never-taken conditional branch to a basic block which falls through to the next function (or end of section). At a high level this is similar to the unreachable warnings mentioned above, in that KCOV isn't fully removing dead code. Treat it the same way by adding these to the list of warnings to ignore with CONFIG_KCOV. Reported-by: Ingo Molnar Reported-by: kernel test robot Signed-off-by: Josh Poimboeuf Signed-off-by: Ingo Molnar Cc: Linus Torvalds Link: https://lore.kernel.org/r/66a61a0b65d74e072d3dc02384e395edb2adc3c5.1742852846.git.jpoimboe@kernel.org Closes: https://lore.kernel.org/Z9iTsI09AEBlxlHC@gmail.com Closes: https://lore.kernel.org/oe-kbuild-all/202503180044.oH9gyPeg-lkp@intel.com/ Signed-off-by: Sasha Levin --- tools/objtool/check.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 6ea78612635ba..b6c91bb5ce3e3 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -3368,6 +3368,9 @@ static int validate_branch(struct objtool_file *file, struct symbol *func, if (!strncmp(func->name, "__cfi_", 6)) return 0; + if (file->ignore_unreachables) + return 0; + WARN("%s() falls through to next function %s()", func->name, insn->func->name); return 1; @@ -3582,6 +3585,9 @@ static int validate_branch(struct objtool_file *file, struct symbol *func, if (!next_insn) { if (state.cfi.cfa.base == CFI_UNDEFINED) return 0; + if (file->ignore_unreachables) + return 0; + WARN("%s: unexpected end of section", sec->name); return 1; } -- 2.39.5