From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EF3125E476 for ; Wed, 9 Apr 2025 15:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744211721; cv=none; b=QV6LXTRwCNX6GiWLlkqVrhkgRj53L/88zjt7AKBnFN6svRV3yMg2tA4qpBfvl/3nMbCwvAO2Nd3uJ29zrub9XZ2HpFPqYeKe7PzzezZA2/tKnonb057eI1oqjOx+TR2ZKM0cO/p37W9e730cqYYQ4+TJoCvBAJZK3szkh9gSGW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744211721; c=relaxed/simple; bh=+hr1leVk+vEvAiLuvc2P3kcQ9inzGoIyYb2ePAU5BBY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EziS/xqlyL3OAm+l1GZGiliUhoCinHiwXyyp8rHj0a+BDQp+Xi3mbkFV+V+swzG42HtnRiHtbigNp0axqF0CPm9G+PTMlA004Lr83DEj7hu328C9Yu0XjVjkpKS6WFd1oHl+OjcpQ9k1W8wBRdJmpuMbCJki5Hnuh0ihiXxjzJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qGAsuyCF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qGAsuyCF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97DC9C4CEE2; Wed, 9 Apr 2025 15:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744211718; bh=+hr1leVk+vEvAiLuvc2P3kcQ9inzGoIyYb2ePAU5BBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qGAsuyCFY9mN4YiIigVo0qC9BC11jhzYB7tXR1yoN/jJmvi7Wy7Z63vhfpidEZ558 tzgLqdBNY36YQ7DIymQaMlsN24/kqBLhYQmhHDuvcshbIsvCCogn6CuwOQn9EeL6vN gDlbb1FgQ9DyNLs48Y5BfJjiA8cGbw0ZuM049hOWvVg4sMOBfbQiNeVh6VHlZOEaVZ xfRaVKRteNNwQYaQhT1xtrTMqOY4e0B5C99dcmY5zAQVHp1L00cMu5NhDfNM/v4PcJ PPHUhwdcEKTlWPYskKJZ2J3KPvAhRDz+JgPIrwOSf0wP6YPl7g2NB9u9Jxs6GizuyQ zMQr6QuXsg4JA== Date: Wed, 9 Apr 2025 17:15:16 +0200 From: Maxime Ripard To: Cristian Ciocaltea Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Dave Stevenson , Dmitry Baryshkov , Dmitry Baryshkov , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 10/15] drm/tests: hdmi: Replace open coded EDID setup Message-ID: <20250409-spectral-persimmon-gorilla-4827ad@houat> References: <20250326-hdmi-conn-yuv-v3-0-294d3ebbb4b2@collabora.com> <20250326-hdmi-conn-yuv-v3-10-294d3ebbb4b2@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hyq7kc3elzthcf4g" Content-Disposition: inline In-Reply-To: <20250326-hdmi-conn-yuv-v3-10-294d3ebbb4b2@collabora.com> --hyq7kc3elzthcf4g Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3 10/15] drm/tests: hdmi: Replace open coded EDID setup MIME-Version: 1.0 On Wed, Mar 26, 2025 at 12:19:59PM +0200, Cristian Ciocaltea wrote: > Make use of the recently introduced macros to reduce boilerplate code > around EDID setup. This also helps dropping the redundant calls to > set_connector_edid(). >=20 > No functional changes intended. >=20 > Signed-off-by: Cristian Ciocaltea > --- > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 220 ++++++++-------= ------ > 1 file changed, 78 insertions(+), 142 deletions(-) >=20 > diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c b/drivers= /gpu/drm/tests/drm_hdmi_state_helper_test.c > index 284bd9b1418a454d05c4a38263519eb8ae450090..7b2aaee5009ce58e6edf2649e= 2182c43ba834523 100644 > --- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c > +++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c > @@ -751,19 +751,15 @@ static void drm_test_check_output_bpc_crtc_mode_cha= nged(struct kunit *test) > struct drm_crtc *crtc; > int ret; > =20 > - priv =3D drm_kunit_helper_connector_hdmi_init(test, > - BIT(HDMI_COLORSPACE_RGB), > - 10); > + priv =3D drm_kunit_helper_connector_hdmi_init_with_edid(test, > + BIT(HDMI_COLORSPACE_RGB), > + 10, > + test_edid_hdmi_1080p_rgb_yuv_dc_max_200mhz); > KUNIT_ASSERT_NOT_NULL(test, priv); > =20 > drm =3D &priv->drm; > crtc =3D priv->crtc; > conn =3D &priv->connector; > - ret =3D set_connector_edid(test, conn, > - test_edid_hdmi_1080p_rgb_yuv_dc_max_200mhz, > - ARRAY_SIZE(test_edid_hdmi_1080p_rgb_yuv_dc_max_200mhz)); > - KUNIT_ASSERT_GT(test, ret, 0); > - Yeah, ok, nvm what I said on the previous patch, it's needed. > preferred =3D find_preferred_mode(conn); > KUNIT_ASSERT_NOT_NULL(test, preferred); > =20 > @@ -830,19 +826,15 @@ static void drm_test_check_output_bpc_crtc_mode_not= _changed(struct kunit *test) > struct drm_crtc *crtc; > int ret; > =20 > - priv =3D drm_kunit_helper_connector_hdmi_init(test, > - BIT(HDMI_COLORSPACE_RGB), > - 10); > + priv =3D drm_kunit_helper_connector_hdmi_init_with_edid(test, > + BIT(HDMI_COLORSPACE_RGB), > + 10, > + test_edid_hdmi_1080p_rgb_yuv_dc_max_200mhz); Alignment is off. Maxime --hyq7kc3elzthcf4g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZ/aPBAAKCRDj7w1vZxhR xc0XAP9a63kRQwFIOR8U0+DDlR4KQjNFtiXjm4xBOWVEheu3HwD/Wc4jrx4iQgQE DXP1igU/FIQ1fA7j/37yxVx4SuH7AQc= =8z5y -----END PGP SIGNATURE----- --hyq7kc3elzthcf4g--