From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Prashanth K <prashanth.k@oss.qualcomm.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Bakker <kees@ijzerbout.nl>,
William McVicker <willmcvicker@google.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@kernel.org" <stable@kernel.org>
Subject: Re: [PATCH v1 1/3] usb: gadget: f_ecm: Add get_status callback
Date: Wed, 9 Apr 2025 00:56:22 +0000 [thread overview]
Message-ID: <20250409005620.qdzbyasz5mpo5ok6@synopsys.com> (raw)
In-Reply-To: <0b210acd-9030-4038-ac7a-480dc2b5db0f@oss.qualcomm.com>
On Tue, Apr 08, 2025, Prashanth K wrote:
>
>
> On 08-04-25 06:38 am, Thinh Nguyen wrote:
> > On Thu, Apr 03, 2025, Prashanth K wrote:
> >> When host sends GET_STATUS to ECM interface, handle the request
> >> from the function driver. Since the interface is wakeup capable,
> >> set the corresponding bit, and set RW bit if the function is
> >> already armed for wakeup by the host.
> >>
> >> Cc: stable@kernel.org
> >> Fixes: 481c225c4802 ("usb: gadget: Handle function suspend feature selector")
> >> Signed-off-by: Prashanth K <prashanth.k@oss.qualcomm.com>
> >> ---
> >> drivers/usb/gadget/function/f_ecm.c | 7 +++++++
> >> 1 file changed, 7 insertions(+)
> >>
> >> diff --git a/drivers/usb/gadget/function/f_ecm.c b/drivers/usb/gadget/function/f_ecm.c
> >> index 80841de845b0..027226325039 100644
> >> --- a/drivers/usb/gadget/function/f_ecm.c
> >> +++ b/drivers/usb/gadget/function/f_ecm.c
> >> @@ -892,6 +892,12 @@ static void ecm_resume(struct usb_function *f)
> >> gether_resume(&ecm->port);
> >> }
> >>
> >> +static int ecm_get_status(struct usb_function *f)
> >> +{
> >> + return (f->func_wakeup_armed ? USB_INTRF_STAT_FUNC_RW : 0) |
> >> + USB_INTRF_STAT_FUNC_RW_CAP;
> >> +}
> >> +
> >
> > Why does USB_INTRF_STAT_FUNC_RW_CAP is set regardless of
> > USB_CONFIG_ATT_WAKEUP?
> >
> We check that in composite.c before calling get_status().
> Have added some comments there [Patch v1 2/3] regarding same.
>
Ok, let's discuss on the other thread.
Thanks,
Thinh
next prev parent reply other threads:[~2025-04-09 0:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 11:08 [PATCH v1 0/3] Fixes for USB3 CV Chapter 9.15 tests Prashanth K
2025-04-03 11:08 ` [PATCH v1 1/3] usb: gadget: f_ecm: Add get_status callback Prashanth K
2025-04-08 1:08 ` Thinh Nguyen
2025-04-08 5:05 ` Prashanth K
2025-04-09 0:56 ` Thinh Nguyen [this message]
2025-04-03 11:08 ` [PATCH v1 2/3] usb: gadget: Use get_status callback to set remote wakeup capability Prashanth K
2025-04-08 1:18 ` Thinh Nguyen
2025-04-08 5:06 ` Prashanth K
2025-04-09 0:55 ` Thinh Nguyen
2025-04-09 4:22 ` Prashanth K
2025-04-09 22:05 ` Thinh Nguyen
2025-04-09 22:12 ` Thinh Nguyen
2025-04-10 6:08 ` Prashanth K
2025-04-11 1:00 ` Thinh Nguyen
2025-04-03 11:08 ` [PATCH v1 3/3] usb: dwc3: gadget: Make gadget_wakeup asynchronous Prashanth K
2025-04-07 23:38 ` Thinh Nguyen
2025-04-08 5:34 ` Prashanth K
2025-04-09 0:43 ` Thinh Nguyen
2025-04-09 4:15 ` Prashanth K
2025-04-09 21:51 ` Thinh Nguyen
2025-04-10 5:48 ` Prashanth K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409005620.qdzbyasz5mpo5ok6@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=kees@ijzerbout.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=prashanth.k@oss.qualcomm.com \
--cc=stable@kernel.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®