From: "Petr Tesařík" <petr@tesarici.cz>
To: iommu@lists.linux.dev
Cc: Petr Tesarik <ptesarik@suse.com>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>, Tom Murphy <murphyt7@tcd.ie>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/vt-d: Remove an unnecessary call set_dma_ops()
Date: Wed, 9 Apr 2025 17:44:30 +0200 [thread overview]
Message-ID: <20250409174430.00ff4a09@meshulam.tesarici.cz> (raw)
In-Reply-To: <20250403165605.278541-1-ptesarik@suse.com>
On Thu, 3 Apr 2025 18:56:05 +0200
Petr Tesarik <ptesarik@suse.com> wrote:
> Do not touch per-device DMA ops when the driver has been converted to use
> the dma-iommu API.
>
> Fixes: c588072bba6b ("iommu/vt-d: Convert intel iommu driver to the iommu ops")
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
Does anyone agree? Or see any issues?
Petr T
> ---
> drivers/iommu/intel/iommu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index bf1f0c814348..b7e500451d4f 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -3789,7 +3789,6 @@ static void intel_iommu_release_device(struct device *dev)
> intel_pasid_free_table(dev);
> intel_iommu_debugfs_remove_dev(info);
> kfree(info);
> - set_dma_ops(dev, NULL);
> }
>
> static void intel_iommu_get_resv_regions(struct device *device,
next prev parent reply other threads:[~2025-04-09 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 16:56 Petr Tesarik
2025-04-09 15:44 ` Petr Tesařík [this message]
2025-04-10 2:59 ` Baolu Lu
2025-04-10 11:33 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409174430.00ff4a09@meshulam.tesarici.cz \
--to=petr@tesarici.cz \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=murphyt7@tcd.ie \
--cc=ptesarik@suse.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®