From: Conor Dooley <conor@kernel.org>
To: Ivan Vecera <ivecera@redhat.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
netdev@vger.kernel.org,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Jiri Pirko <jiri@resnulli.us>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Prathosh Satish <Prathosh.Satish@microchip.com>,
Lee Jones <lee@kernel.org>, Kees Cook <kees@kernel.org>,
Andy Shevchenko <andy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Schmidt <mschmidt@redhat.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 02/14] dt-bindings: dpll: Add support for Microchip Azurite chip family
Date: Thu, 10 Apr 2025 14:18:05 +0100 [thread overview]
Message-ID: <20250410-puritan-flatbed-00bf339297c0@spud> (raw)
In-Reply-To: <1a78fc71-fcf6-446e-9ada-c14420f9c5fe@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2865 bytes --]
On Thu, Apr 10, 2025 at 09:45:47AM +0200, Ivan Vecera wrote:
>
>
> On 10. 04. 25 9:06 dop., Krzysztof Kozlowski wrote:
> > On Wed, Apr 09, 2025 at 04:42:38PM GMT, Ivan Vecera wrote:
> > > Add DT bindings for Microchip Azurite DPLL chip family. These chips
> > > provides 2 independent DPLL channels, up to 10 differential or
> > > single-ended inputs and up to 20 differential or 20 single-ended outputs.
> > > It can be connected via I2C or SPI busses.
> > >
> > > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> > > ---
> > > .../bindings/dpll/microchip,zl3073x-i2c.yaml | 74 ++++++++++++++++++
> > > .../bindings/dpll/microchip,zl3073x-spi.yaml | 77 +++++++++++++++++++
> >
> > No, you do not get two files. No such bindings were accepted since some
> > years.
> >
> > > 2 files changed, 151 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/dpll/microchip,zl3073x-i2c.yaml
> > > create mode 100644 Documentation/devicetree/bindings/dpll/microchip,zl3073x-spi.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/dpll/microchip,zl3073x-i2c.yaml b/Documentation/devicetree/bindings/dpll/microchip,zl3073x-i2c.yaml
> > > new file mode 100644
> > > index 0000000000000..d9280988f9eb7
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/dpll/microchip,zl3073x-i2c.yaml
> > > @@ -0,0 +1,74 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/dpll/microchip,zl3073x-i2c.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: I2C-attached Microchip Azurite DPLL device
> > > +
> > > +maintainers:
> > > + - Ivan Vecera <ivecera@redhat.com>
> > > +
> > > +description:
> > > + Microchip Azurite DPLL (ZL3073x) is a family of DPLL devices that
> > > + provides 2 independent DPLL channels, up to 10 differential or
> > > + single-ended inputs and up to 20 differential or 20 single-ended outputs.
> > > + It can be connected via multiple busses, one of them being I2C.
> > > +
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + - microchip,zl3073x-i2c
> >
> > I already said: you have one compatible, not two. One.
>
> Ah, you mean something like:
> iio/accel/adi,adxl313.yaml
>
> Do you?
>
> > Also, still wildcard, so still a no.
>
> This is not wildcard, Microchip uses this to designate DPLL devices with the
> same characteristics.
That's the very definition of a wildcard, no? The x is matching against
several different devices. There's like 14 different parts matching
zl3073x, with varying numbers of outputs and channels. One compatible
for all of that hardly seems suitable.
>
> But I can use microchip,azurite, is it more appropriate?
No, I think that is worse actually.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-04-10 13:18 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 14:42 [PATCH v2 00/14] Add Microchip ZL3073x support (part 1) Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 01/14] dt-bindings: dpll: Add device tree bindings for DPLL device and pin Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 02/14] dt-bindings: dpll: Add support for Microchip Azurite chip family Ivan Vecera
2025-04-10 7:06 ` Krzysztof Kozlowski
2025-04-10 7:45 ` Ivan Vecera
2025-04-10 13:18 ` Conor Dooley [this message]
2025-04-10 13:35 ` Ivan Vecera
2025-04-10 17:07 ` Prathosh.Satish
2025-04-10 17:36 ` Ivan Vecera
2025-04-10 18:36 ` Prathosh.Satish
2025-04-10 17:36 ` Andrew Lunn
2025-04-10 18:33 ` Ivan Vecera
2025-04-10 21:12 ` Andrew Lunn
2025-04-11 9:56 ` Ivan Vecera
2025-04-14 17:19 ` Conor Dooley
2025-04-09 14:42 ` [PATCH v2 03/14] mfd: Add Microchip ZL3073x support Ivan Vecera
2025-04-09 15:43 ` Andy Shevchenko
2025-04-10 7:19 ` Krzysztof Kozlowski
2025-04-10 7:52 ` Ivan Vecera
2025-04-10 17:50 ` Andrew Lunn
2025-04-10 18:36 ` Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 04/14] mfd: zl3073x: Register itself as devlink device Ivan Vecera
2025-04-19 12:40 ` kernel test robot
2025-04-19 14:03 ` kernel test robot
2025-04-09 14:42 ` [PATCH v2 05/14] mfd: zl3073x: Add register access helpers Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 06/14] mfd: zl3073x: Add macros for device registers access Ivan Vecera
2025-04-10 7:17 ` Krzysztof Kozlowski
2025-04-10 8:20 ` Ivan Vecera
2025-04-10 17:53 ` Andy Shevchenko
2025-04-13 10:18 ` Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 07/14] mfd: zl3073x: Add components versions register defs Ivan Vecera
2025-04-10 7:13 ` Krzysztof Kozlowski
2025-04-10 8:26 ` Ivan Vecera
2025-04-10 17:41 ` Andrew Lunn
2025-04-10 18:44 ` Ivan Vecera
2025-04-10 21:54 ` Andrew Lunn
2025-04-15 10:01 ` Ivan Vecera
2025-04-15 11:16 ` Andy Shevchenko
2025-04-15 12:57 ` Andrew Lunn
2025-04-15 14:20 ` Ivan Vecera
2025-04-10 17:50 ` Andy Shevchenko
2025-04-11 11:19 ` Ivan Vecera
2025-04-11 12:31 ` Andrew Lunn
2025-04-11 13:19 ` Ivan Vecera
2025-04-11 13:17 ` Ivan Vecera
2025-04-13 19:50 ` Andrew Lunn
2025-04-09 14:42 ` [PATCH v2 08/14] mfd: zl3073x: Implement devlink device info Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 09/14] mfd: zl3073x: Add macro to wait for register value bits to be cleared Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 10/14] mfd: zl3073x: Add functions to work with register mailboxes Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 11/14] mfd: zl3073x: Add clock_id field Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 12/14] lib: Allow modules to use strnchrnul Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 13/14] mfd: zl3073x: Load mfg file into HW if it is present Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 14/14] mfd: zl3073x: Fetch invariants during probe Ivan Vecera
2025-04-10 0:17 ` [PATCH v2 00/14] Add Microchip ZL3073x support (part 1) Jakub Kicinski
2025-04-10 9:18 ` Ivan Vecera
2025-04-10 17:26 ` Andrew Lunn
2025-04-10 22:57 ` Jakub Kicinski
2025-04-11 7:45 ` Ivan Vecera
2025-04-10 7:29 ` Lee Jones
2025-04-11 7:26 ` Lee Jones
2025-04-11 8:01 ` Ivan Vecera
2025-04-11 14:27 ` Michal Schmidt
2025-04-11 14:38 ` Michal Schmidt
2025-04-11 15:58 ` Rob Herring
2025-04-15 10:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410-puritan-flatbed-00bf339297c0@spud \
--to=conor@kernel.org \
--cc=Prathosh.Satish@microchip.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=arkadiusz.kubalewski@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®