From: Peter Seiderer <ps.report@gmx.net>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Peter Seiderer <ps.report@gmx.net>
Subject: [PATCH net-next v1 11/11] net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy)
Date: Thu, 10 Apr 2025 09:17:48 +0200 [thread overview]
Message-ID: <20250410071749.30505-12-ps.report@gmx.net> (raw)
In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net>
Fix checkpatch code style warnings:
WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
#1422: FILE: net/core/pktgen.c:1422:
+ strcpy(pkt_dev->dst_min, buf);
WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
#1443: FILE: net/core/pktgen.c:1443:
+ strcpy(pkt_dev->dst_max, buf);
WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
#1553: FILE: net/core/pktgen.c:1553:
+ strcpy(pkt_dev->src_min, buf);
WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
#1574: FILE: net/core/pktgen.c:1574:
+ strcpy(pkt_dev->src_max, buf);
WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
#3227: FILE: net/core/pktgen.c:3227:
+ strcpy(pkt_dev->result, "Starting");
WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
#3231: FILE: net/core/pktgen.c:3231:
+ strcpy(pkt_dev->result, "Error starting");
WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
#3845: FILE: net/core/pktgen.c:3845:
+ strcpy(pkt_dev->odevname, ifname);
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
net/core/pktgen.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 0d18fd932ed9..3f76cae9cf57 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -1419,7 +1419,7 @@ static ssize_t pktgen_if_write(struct file *file,
buf[len] = 0;
if (strcmp(buf, pkt_dev->dst_min) != 0) {
memset(pkt_dev->dst_min, 0, sizeof(pkt_dev->dst_min));
- strcpy(pkt_dev->dst_min, buf);
+ strscpy(pkt_dev->dst_min, buf);
pkt_dev->daddr_min = in_aton(pkt_dev->dst_min);
pkt_dev->cur_daddr = pkt_dev->daddr_min;
}
@@ -1440,7 +1440,7 @@ static ssize_t pktgen_if_write(struct file *file,
buf[len] = 0;
if (strcmp(buf, pkt_dev->dst_max) != 0) {
memset(pkt_dev->dst_max, 0, sizeof(pkt_dev->dst_max));
- strcpy(pkt_dev->dst_max, buf);
+ strscpy(pkt_dev->dst_max, buf);
pkt_dev->daddr_max = in_aton(pkt_dev->dst_max);
pkt_dev->cur_daddr = pkt_dev->daddr_max;
}
@@ -1550,7 +1550,7 @@ static ssize_t pktgen_if_write(struct file *file,
buf[len] = 0;
if (strcmp(buf, pkt_dev->src_min) != 0) {
memset(pkt_dev->src_min, 0, sizeof(pkt_dev->src_min));
- strcpy(pkt_dev->src_min, buf);
+ strscpy(pkt_dev->src_min, buf);
pkt_dev->saddr_min = in_aton(pkt_dev->src_min);
pkt_dev->cur_saddr = pkt_dev->saddr_min;
}
@@ -1571,7 +1571,7 @@ static ssize_t pktgen_if_write(struct file *file,
buf[len] = 0;
if (strcmp(buf, pkt_dev->src_max) != 0) {
memset(pkt_dev->src_max, 0, sizeof(pkt_dev->src_max));
- strcpy(pkt_dev->src_max, buf);
+ strscpy(pkt_dev->src_max, buf);
pkt_dev->saddr_max = in_aton(pkt_dev->src_max);
pkt_dev->cur_saddr = pkt_dev->saddr_max;
}
@@ -3224,11 +3224,11 @@ static void pktgen_run(struct pktgen_thread *t)
set_pkt_overhead(pkt_dev);
- strcpy(pkt_dev->result, "Starting");
+ strscpy(pkt_dev->result, "Starting");
pkt_dev->running = 1; /* Cranke yeself! */
started++;
} else
- strcpy(pkt_dev->result, "Error starting");
+ strscpy(pkt_dev->result, "Error starting");
}
rcu_read_unlock();
if (started)
@@ -3842,7 +3842,7 @@ static int pktgen_add_device(struct pktgen_thread *t, const char *ifname)
if (!pkt_dev)
return -ENOMEM;
- strcpy(pkt_dev->odevname, ifname);
+ strscpy(pkt_dev->odevname, ifname);
pkt_dev->flows = vzalloc_node(array_size(MAX_CFLOWS,
sizeof(struct flow_state)),
node);
--
2.49.0
next prev parent reply other threads:[~2025-04-10 7:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 7:17 [PATCH net-next v1 00/11] net: pktgen: fix checkpatch code style errors/warnings Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 01/11] net: pktgen: fix code style (ERROR: "foo * bar" should be "foo *bar") Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 02/11] net: pktgen: fix code style (ERROR: space prohibited after that '&') Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 03/11] net: pktgen: fix code style (ERROR: else should follow close brace '}') Peter Seiderer
2025-04-14 21:48 ` Jakub Kicinski
2025-04-10 7:17 ` [PATCH net-next v1 04/11] net: pktgen: fix code style (WARNING: please, no space before tabs) Peter Seiderer
2025-04-14 21:49 ` Jakub Kicinski
2025-04-10 7:17 ` [PATCH net-next v1 05/11] net: pktgen: fix code style (WARNING: suspect code indent for conditional statements) Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 06/11] net: pktgen: fix code style (WARNING: Block comments) Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 07/11] net: pktgen: fix code style (WARNING: Missing a blank line after declarations) Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 08/11] net: pktgen: fix code style (WARNING: macros should not use a trailing semicolon) Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 09/11] net: pktgen: fix code style (WARNING: braces {} are not necessary for single statement blocks) Peter Seiderer
2025-04-14 21:51 ` Jakub Kicinski
2025-04-10 7:17 ` [PATCH net-next v1 10/11] net: pktgen: fix code style (WARNING: quoted string split across lines) Peter Seiderer
2025-04-10 7:17 ` Peter Seiderer [this message]
2025-04-14 21:52 ` [PATCH net-next v1 11/11] net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy) Jakub Kicinski
2025-04-10 11:24 ` [PATCH net-next v1 00/11] net: pktgen: fix checkpatch code style errors/warnings Toke Høiland-Jørgensen
2025-04-14 22:57 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410071749.30505-12-ps.report@gmx.net \
--to=ps.report@gmx.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®