From: Chao Gao <chao.gao@intel.com>
To: x86@kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, tglx@linutronix.de, dave.hansen@intel.com,
seanjc@google.com, pbonzini@redhat.com
Cc: peterz@infradead.org, rick.p.edgecombe@intel.com,
weijiang.yang@intel.com, john.allen@amd.com, bp@alien8.de,
chang.seok.bae@intel.com, xin3.li@intel.com,
Chao Gao <chao.gao@intel.com>, Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Eric Biggers <ebiggers@google.com>,
Stanislav Spassov <stanspas@amazon.de>
Subject: [PATCH v5 4/7] x86/fpu: Initialize guest FPU permissions from guest defaults
Date: Thu, 10 Apr 2025 15:24:44 +0800 [thread overview]
Message-ID: <20250410072605.2358393-5-chao.gao@intel.com> (raw)
In-Reply-To: <20250410072605.2358393-1-chao.gao@intel.com>
Currently, fpu->guest_perm is copied from fpu->perm, which is derived from
fpu_kernel_cfg.default_features.
Guest defaults were introduced to differentiate the features and sizes of
host and guest FPUs. Copying guest FPU permissions from the host will lead
to inconsistencies between the guest default features and permissions.
Initialize guest FPU permissions from guest defaults instead of host
defaults. This ensures that any changes to guest default features are
automatically reflected in guest permissions, which in turn guarantees
that fpstate_realloc() allocates a correctly sized XSAVE buffer for guest
FPUs.
Suggested-by: Chang S. Bae <chang.seok.bae@intel.com>
Signed-off-by: Chao Gao <chao.gao@intel.com>
---
arch/x86/kernel/fpu/core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/fpu/core.c b/arch/x86/kernel/fpu/core.c
index 25f13cc8ad92..e23e435b85c4 100644
--- a/arch/x86/kernel/fpu/core.c
+++ b/arch/x86/kernel/fpu/core.c
@@ -543,8 +543,10 @@ void fpstate_reset(struct fpu *fpu)
fpu->perm.__state_perm = fpu_kernel_cfg.default_features;
fpu->perm.__state_size = fpu_kernel_cfg.default_size;
fpu->perm.__user_state_size = fpu_user_cfg.default_size;
- /* Same defaults for guests */
- fpu->guest_perm = fpu->perm;
+
+ fpu->guest_perm.__state_perm = guest_default_cfg.features;
+ fpu->guest_perm.__state_size = guest_default_cfg.size;
+ fpu->guest_perm.__user_state_size = guest_default_cfg.user_size;
}
static inline void fpu_inherit_perms(struct fpu *dst_fpu)
--
2.46.1
next prev parent reply other threads:[~2025-04-10 7:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 7:24 [PATCH v5 0/7] Introduce CET supervisor state support Chao Gao
2025-04-10 7:24 ` [PATCH v5 1/7] x86/fpu/xstate: Always preserve non-user xfeatures/flags in __state_perm Chao Gao
2025-04-18 20:50 ` Chang S. Bae
2025-04-10 7:24 ` [PATCH v5 2/7] x86/fpu: Drop @perm from guest pseudo FPU container Chao Gao
2025-04-18 20:51 ` Chang S. Bae
2025-04-18 20:54 ` Chang S. Bae
2025-04-19 1:01 ` Chao Gao
2025-04-10 7:24 ` [PATCH v5 3/7] x86/fpu/xstate: Differentiate default features for host and guest FPUs Chao Gao
2025-04-24 22:52 ` Edgecombe, Rick P
2025-04-25 8:24 ` Chao Gao
2025-04-25 16:09 ` Edgecombe, Rick P
2025-04-25 23:48 ` Sean Christopherson
2025-04-28 3:26 ` Chao Gao
2025-04-28 7:44 ` Xin Li
2025-04-28 14:28 ` Sean Christopherson
2025-04-28 6:31 ` Xin Li
2025-04-28 15:42 ` Edgecombe, Rick P
2025-04-29 1:11 ` Chang S. Bae
2025-04-29 2:50 ` Edgecombe, Rick P
2025-04-29 3:22 ` Chang S. Bae
2025-04-29 3:36 ` Edgecombe, Rick P
2025-04-30 3:27 ` Chao Gao
2025-04-30 15:01 ` Chang S. Bae
2025-04-30 15:33 ` Edgecombe, Rick P
2025-04-30 16:20 ` Sean Christopherson
2025-04-30 18:26 ` Chang S. Bae
2025-04-28 5:51 ` Xin Li
2025-04-28 6:12 ` Xin Li
2025-05-01 14:24 ` Chang S. Bae
2025-05-06 3:29 ` Chao Gao
2025-04-10 7:24 ` Chao Gao [this message]
2025-04-30 15:45 ` [PATCH v5 4/7] x86/fpu: Initialize guest FPU permissions from guest defaults Edgecombe, Rick P
2025-04-10 7:24 ` [PATCH v5 5/7] x86/fpu: Initialize guest fpstate and FPU pseudo container " Chao Gao
2025-04-30 18:29 ` Edgecombe, Rick P
2025-05-01 14:24 ` Chang S. Bae
2025-05-06 3:33 ` Chao Gao
2025-04-10 7:24 ` [PATCH v5 6/7] x86/fpu/xstate: Introduce "guest-only" supervisor xfeature set Chao Gao
2025-04-24 22:58 ` Edgecombe, Rick P
2025-04-10 7:24 ` [PATCH v5 7/7] x86/fpu/xstate: Add CET supervisor xfeature support as a guest-only feature Chao Gao
2025-04-24 23:28 ` [PATCH v5 0/7] Introduce CET supervisor state support Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410072605.2358393-5-chao.gao@intel.com \
--to=chao.gao@intel.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=ebiggers@google.com \
--cc=hpa@zytor.com \
--cc=john.allen@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=stanspas@amazon.de \
--cc=tglx@linutronix.de \
--cc=weijiang.yang@intel.com \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®