From: Stefano Garzarella <sgarzare@redhat.com>
To: Borislav Petkov <bp@alien8.de>, Jarkko Sakkinen <jarkko@kernel.org>
Cc: Joerg Roedel <jroedel@suse.de>, "H. Peter Anvin" <hpa@zytor.com>,
Dionna Glaze <dionnaglaze@google.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Dov Murik <dovmurik@linux.ibm.com>,
linux-integrity@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Claudio Carvalho <cclaudio@linux.ibm.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
x86@kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-coco@lists.linux.dev,
Stefano Garzarella <sgarzare@redhat.com>
Subject: [PATCH v7 4/4] x86/sev: register tpm-svsm platform device
Date: Thu, 10 Apr 2025 15:51:16 +0200 [thread overview]
Message-ID: <20250410135118.133240-5-sgarzare@redhat.com> (raw)
In-Reply-To: <20250410135118.133240-1-sgarzare@redhat.com>
From: Stefano Garzarella <sgarzare@redhat.com>
SNP platform can provide a vTPM device emulated by SVSM.
The "tpm-svsm" device can be handled by the platform driver added
by the previous commit in drivers/char/tpm/tpm_svsm.c
Register the platform device only when SVSM is available and it
supports vTPM commands as checked by snp_svsm_vtpm_probe().
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
v7:
- added Jarkko's R-b
- call snp_svsm_vtpm_probe() before registering the device [Borislav]
- s/device/devices in pr_info [Tom]
- updated commit description
v6:
- added Tom's R-b
v4:
- explained better why we register it anyway in the commit message
---
arch/x86/coco/sev/core.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
index 3bc5b47e7304..54272c9777cf 100644
--- a/arch/x86/coco/sev/core.c
+++ b/arch/x86/coco/sev/core.c
@@ -2688,6 +2688,11 @@ static struct platform_device sev_guest_device = {
.id = -1,
};
+static struct platform_device tpm_svsm_device = {
+ .name = "tpm-svsm",
+ .id = -1,
+};
+
static int __init snp_init_platform_device(void)
{
if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP))
@@ -2696,7 +2701,11 @@ static int __init snp_init_platform_device(void)
if (platform_device_register(&sev_guest_device))
return -ENODEV;
- pr_info("SNP guest platform device initialized.\n");
+ if (snp_svsm_vtpm_probe() &&
+ platform_device_register(&tpm_svsm_device))
+ return -ENODEV;
+
+ pr_info("SNP guest platform devices initialized.\n");
return 0;
}
device_initcall(snp_init_platform_device);
--
2.49.0
next prev parent reply other threads:[~2025-04-10 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 13:51 [PATCH v7 0/4] Enlightened vTPM support for SVSM on SEV-SNP Stefano Garzarella
2025-04-10 13:51 ` [PATCH v7 1/4] x86/sev: add SVSM vTPM probe/send_command functions Stefano Garzarella
2025-04-10 13:51 ` [PATCH v7 2/4] svsm: add header with SVSM_VTPM_CMD helpers Stefano Garzarella
2025-04-10 13:51 ` [PATCH v7 3/4] tpm: add SNP SVSM vTPM driver Stefano Garzarella
2025-04-11 10:15 ` [tip: x86/sev] tpm: Add " tip-bot2 for Stefano Garzarella
2025-04-10 13:51 ` Stefano Garzarella [this message]
2025-04-11 10:15 ` [tip: x86/sev] x86/sev: Register tpm-svsm platform device tip-bot2 for Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410135118.133240-5-sgarzare@redhat.com \
--to=sgarzare@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bp@alien8.de \
--cc=cclaudio@linux.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=dionnaglaze@google.com \
--cc=dovmurik@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jroedel@suse.de \
--cc=linux-coco@lists.linux.dev \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterhuewe@gmx.de \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®