From: Peter Zijlstra <peterz@infradead.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Paweł Anikiel" <panikiel@google.com>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Kees Cook" <kees@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Josh Poimboeuf" <jpoimboe@kernel.org>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Alice Ryhl" <aliceryhl@google.com>,
"Nathan Chancellor" <nathan@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] x86/Kconfig: make CFI_AUTO_DEFAULT depend on !RUST
Date: Thu, 10 Apr 2025 16:15:34 +0200 [thread overview]
Message-ID: <20250410141534.GI9833@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CANiq72=uj3G8ibnzpuYzhY=7T5xrBBPoeuAX7X-iBKdN+crQUg@mail.gmail.com>
On Thu, Apr 10, 2025 at 04:05:54PM +0200, Miguel Ojeda wrote:
> On Thu, Apr 10, 2025 at 3:57 PM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > Remove the offending Rust code? Afaict from this github issue, it is
> > just some formatting nonsense. Surely code can be adjusted to not use
> > that?
>
> If you mean not using the formatting machinery from our side, then
> that is a major change -- we should just fix it upstream, really.
That is what I mean, yeah. I've no idea what is or is not common in
this rust code. It still looks like line noise to me :/
But given that FineIBT isn't at all new, I was under the assumption that
this was some shiny new rust driver that did something that hadn't been
done before. And it could now not do that.
> If you mean fixing it upstream, definitely, but we should still
> prevent people from building an invalid kernel, i.e. when Alice's PR
> or similar lands upstream, then we can relax the `depends on` based on
> the Rust version (which is something we have done for other bits).
So why wasn't any of this a problem when Rust enabled kCFI? Surely the
testing back then included FineIBT. That has been in longer than rust's
kcfi support (integer type confusion etc.).
next prev parent reply other threads:[~2025-04-10 14:15 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 11:54 Paweł Anikiel
2025-04-10 12:36 ` Peter Zijlstra
2025-04-10 12:45 ` Peter Zijlstra
2025-04-10 13:09 ` Peter Zijlstra
2025-04-10 13:18 ` Paweł Anikiel
2025-04-10 13:20 ` Alice Ryhl
2025-04-10 13:21 ` Miguel Ojeda
2025-04-10 13:26 ` Peter Zijlstra
2025-04-10 13:27 ` Miguel Ojeda
2025-04-10 13:34 ` Peter Zijlstra
2025-04-10 13:54 ` Miguel Ojeda
2025-04-10 13:57 ` Peter Zijlstra
2025-04-10 14:05 ` Miguel Ojeda
2025-04-10 14:15 ` Peter Zijlstra [this message]
2025-04-10 15:04 ` Alice Ryhl
2025-04-10 13:59 ` Alice Ryhl
2025-04-10 14:08 ` Peter Zijlstra
2025-04-10 14:54 ` Miguel Ojeda
2025-04-10 15:14 ` Peter Zijlstra
2025-04-10 18:01 ` Miguel Ojeda
2025-04-10 15:02 ` Alice Ryhl
2025-04-15 15:15 ` Miguel Ojeda
2025-04-16 10:38 ` Alice Ryhl
2025-04-16 20:20 ` Peter Zijlstra
2025-04-16 21:51 ` Kees Cook
2025-04-17 8:18 ` Peter Zijlstra
2025-04-17 18:40 ` Miguel Ojeda
2025-04-18 9:45 ` Peter Zijlstra
2025-05-06 22:19 ` Miguel Ojeda
2025-05-09 8:46 ` Alice Ryhl
2025-05-09 9:04 ` Miguel Ojeda
2025-05-09 9:11 ` Paweł Anikiel
2025-05-09 9:39 ` Alice Ryhl
2025-05-09 16:34 ` Kees Cook
2025-05-09 19:33 ` Miguel Ojeda
2025-04-10 13:12 ` Paweł Anikiel
2025-04-10 13:25 ` Peter Zijlstra
2025-04-10 15:45 ` [PATCH] objtool: Detect __nocfi calls Peter Zijlstra
2025-04-10 19:09 ` Josh Poimboeuf
2025-04-11 6:46 ` Peter Zijlstra
2025-04-10 19:32 ` Miguel Ojeda
2025-04-10 19:43 ` Sami Tolvanen
2025-04-11 6:44 ` Peter Zijlstra
2025-04-12 12:31 ` Peter Zijlstra
2025-04-10 13:50 ` [PATCH] x86/Kconfig: make CFI_AUTO_DEFAULT depend on !RUST Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410141534.GI9833@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
--cc=panikiel@google.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome