mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Armin Wolf <W_Armin@gmx.de>
To: rafael@kernel.org, rui.zhang@intel.com
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] ACPI: thermal: Properly support the _SCP control method
Date: Thu, 10 Apr 2025 18:54:53 +0200	[thread overview]
Message-ID: <20250410165456.4173-1-W_Armin@gmx.de> (raw)

The ACPI specification defines an interface for the operating system
to change the preferred cooling mode of a given ACPI thermal zone.
This interface takes the form of a special ACPI control method called
_SCP (see section 11.4.13 for details) and is already supported by the
ACPI thermal driver.

However this support as many issues:

 - the kernel advertises support for the "3.0 _SCP Extensions" yet the
   ACPI thermal driver does not support those extensions. This may
   confuse the ACPI firmware.

 - the execution of the _SCP control method happens after the driver
   retrieved the trip point values. This conflicts with the ACPI
   specification:

	"OSPM will automatically evaluate _ACx and _PSV objects after
	 executing _SCP."

 - the cooling mode is hardcoded to active cooling and cannot be
   changed by the user.

Those issues are fixed in this patch series. In the end the user
will be able to tell the ACPI firmware wether he prefers active or
passive cooling. This setting will also be interesting for
applications like TLP (https://linrunner.de/tlp/index.html).

The whole series was tested on various devices supporting the _SCP
control method and on a device without the _SCP control method and
appears to work flawlessly.

Armin Wolf (3):
  ACPI: OSI: Stop advertising support for "3.0 _SCP Extensions"
  ACPI: thermal: Execute _SCP before reading trip points
  ACPI: thermal: Allow userspace applications to change the cooling mode

 .../ABI/testing/sysfs-driver-thermal          |  14 ++
 MAINTAINERS                                   |   1 +
 drivers/acpi/osi.c                            |   1 -
 drivers/acpi/thermal.c                        | 129 ++++++++++++++++--
 4 files changed, 133 insertions(+), 12 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-driver-thermal

--
2.39.5


             reply	other threads:[~2025-04-10 16:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10 16:54 Armin Wolf [this message]
2025-04-10 16:54 ` [PATCH 1/3] ACPI: OSI: Stop advertising support for "3.0 _SCP Extensions" Armin Wolf
2025-04-10 16:54 ` [PATCH 2/3] ACPI: thermal: Execute _SCP before reading trip points Armin Wolf
2025-04-10 16:54 ` [PATCH 3/3] ACPI: thermal: Allow userspace applications to change the cooling mode Armin Wolf
2025-04-25 23:20 ` [PATCH 0/3] ACPI: thermal: Properly support the _SCP control method Armin Wolf
2025-04-26 13:12   ` Rafael J. Wysocki
2025-04-26 22:52     ` Armin Wolf
2025-04-28 12:31       ` Armin Wolf
2025-04-28 12:34         ` Rafael J. Wysocki
2025-05-02 22:29           ` Armin Wolf
2025-05-16 13:59             ` Rafael J. Wysocki
2025-05-16 16:56               ` Rafael J. Wysocki
2025-05-16 22:51                 ` Armin Wolf
2025-05-16 23:01               ` Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250410165456.4173-1-W_Armin@gmx.de \
    --to=w_armin@gmx.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®