mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Zijun Hu <zijun_hu@icloud.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
	 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zijun Hu <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH RFC] fs/fs_context: Use KERN_INFO for infof()|info_plog()|infofc()
Date: Fri, 11 Apr 2025 16:10:36 +0200	[thread overview]
Message-ID: <20250411-fahrbahn-vortrag-ea3a07c30754@brauner> (raw)
In-Reply-To: <20250410-rfc_fix_fs-v1-1-406e13b3608e@quicinc.com>

On Thu, Apr 10, 2025 at 07:53:03PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
> 
> Use KERN_INFO instead of default KERN_NOTICE for
> infof()|info_plog()|infofc() to printk informational messages.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
>  fs/fs_context.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/fs_context.c b/fs/fs_context.c
> index 582d33e8111739402d38dc9fc268e7d14ced3c49..2877d9dec0753a5f03e0a54fa7b8d25072ea7b4d 100644
> --- a/fs/fs_context.c
> +++ b/fs/fs_context.c
> @@ -449,6 +449,10 @@ void logfc(struct fc_log *log, const char *prefix, char level, const char *fmt,
>  			printk(KERN_ERR "%s%s%pV\n", prefix ? prefix : "",
>  						prefix ? ": " : "", &vaf);
>  			break;
> +		case 'i':
> +			printk(KERN_INFO "%s%s%pV\n", prefix ? prefix : "",
> +						prefix ? ": " : "", &vaf);

We can try but it's not out of the question that this might cause users
to complain or cause regressions.

> +			break;
>  		default:
>  			printk(KERN_NOTICE "%s%s%pV\n", prefix ? prefix : "",
>  						prefix ? ": " : "", &vaf);
> 
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> change-id: 20250410-rfc_fix_fs-cfa369930abe
> 
> Best regards,
> -- 
> Zijun Hu <quic_zijuhu@quicinc.com>
> 

  reply	other threads:[~2025-04-11 14:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10 11:53 Zijun Hu
2025-04-11 14:10 ` Christian Brauner [this message]
2025-04-11 14:11 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250411-fahrbahn-vortrag-ea3a07c30754@brauner \
    --to=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_zijuhu@quicinc.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zijun_hu@icloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®