From: Sudeep Holla <sudeep.holla@arm.com>
To: Stuart Yoder <stuart.yoder@arm.com>
Cc: <linux-integrity@vger.kernel.org>, <jarkko@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>, <peterhuewe@gmx.de>,
<jgg@ziepe.ca>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm_crb: ffa_tpm: return errors from interface functions if no ffa-crb driver
Date: Mon, 14 Apr 2025 16:18:07 +0100 [thread overview]
Message-ID: <20250414-tiny-swan-of-tempest-ddcbdd@sudeepholla> (raw)
In-Reply-To: <20250414145235.938924-1-stuart.yoder@arm.com>
On Mon, Apr 14, 2025 at 09:52:35AM -0500, Stuart Yoder wrote:
> If ACPI advertises an FF-A based TPM but the tpm_crb_ffa driver is not
> enabled via Kconfig, inline stub versions of the interface functions
> are used. These functions incorrectly return 0, which indicates success.
> The result is that the tpm_crb probe function continues execution and
> eventually detects a timeout at the TPM.
>
> Change the inline functions to return errors, so that probe() sees that
> tpm_crb_ffa is not present and aborts the probe.
>
LGTM,
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
prev parent reply other threads:[~2025-04-14 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 14:52 Stuart Yoder
2025-04-14 15:18 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250414-tiny-swan-of-tempest-ddcbdd@sudeepholla \
--to=sudeep.holla@arm.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stuart.yoder@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®