From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 697EF299655; Mon, 14 Apr 2025 13:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744637362; cv=none; b=bYYbIdhg+dVcLo7oX47rgV7hQ+jZg7hwR1MmQh8OIMWUyQ9q9PGXe0k+3Lo4Ah1cR3mPxituFrM6FOmvX+xbt6gdU1VMZV8y2oK5cIafGIkzElRFkyGZVjnOBXk5/YE5iZuOGd+MUrlwzj9MxUXArL/T/Y6rMO6j8gi/vGjobZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744637362; c=relaxed/simple; bh=Pg6gCQBdEpkh4I0IgeWbw45o0IqIzFFpIq3s+sJzhjE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DJsbVFtAURRgkfDWBo2sKkuOOr/xWsBxiRjVgOlg4mUEj4bhOuKY77cIGoqpQBMkJrGkHkjt65aGD1n1fC7cqtoYAe3q7oly9BRvQ8JVdKxL5hG5X0BvKJyOznAYwMZGC3gITkFRh/JMaruRoqm45R79YEsO88qUtd/nwEaS+fQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RElN7r77; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RElN7r77" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAAABC4CEE9; Mon, 14 Apr 2025 13:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744637361; bh=Pg6gCQBdEpkh4I0IgeWbw45o0IqIzFFpIq3s+sJzhjE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RElN7r77S5yWeybi5dbMERozugb2jENe79wBMaCC3loszV37oarvgwkVsOdoXqPA5 COO5OspkEOrfxzrcHwwUeLsDykD3SL4jyMiNU4/6c9DeUMz3FrcsSAzH6IZK2MGRlb EvqChYeqEVDJ5XywFxalxUfnM9ZJSizf4rOUKnmXTg78AzYlau4e9Dm018IgSx6DD0 LYFFCT0SV6giEj22vUXGuB/7I+M+Qx4vZbyYBnC4Xm4qRJhHvfAYbZNPUFyag3WvMH RZhiCs8iad8FYcn8Aei4jGQwRfRNrLM4gekxVoO7kyLO40S47WGgUXxm0oQPfV74KG 2Yy2iQGk4kWFg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hannes Reinecke , Keith Busch , Christoph Hellwig , Sasha Levin , sagi@grimberg.me, linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 6.12 13/30] nvme: re-read ANA log page after ns scan completes Date: Mon, 14 Apr 2025 09:28:30 -0400 Message-Id: <20250414132848.679855-13-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250414132848.679855-1-sashal@kernel.org> References: <20250414132848.679855-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.12.23 Content-Transfer-Encoding: 8bit From: Hannes Reinecke [ Upstream commit 62baf70c327444338c34703c71aa8cc8e4189bd6 ] When scanning for new namespaces we might have missed an ANA AEN. The NVMe base spec (NVMe Base Specification v2.1, Figure 151 'Asynchonous Event Information - Notice': Asymmetric Namespace Access Change) states: A controller shall not send this even if an Attached Namespace Attribute Changed asynchronous event [...] is sent for the same event. so we need to re-read the ANA log page after we rescanned the namespace list to update the ANA states of the new namespaces. Signed-off-by: Hannes Reinecke Reviewed-by: Keith Busch Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/host/core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 587385b59b865..f7519c07ed3c4 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -4277,6 +4277,11 @@ static void nvme_scan_work(struct work_struct *work) /* Requeue if we have missed AENs */ if (test_bit(NVME_AER_NOTICE_NS_CHANGED, &ctrl->events)) nvme_queue_scan(ctrl); +#ifdef CONFIG_NVME_MULTIPATH + else + /* Re-read the ANA log page to not miss updates */ + queue_work(nvme_wq, &ctrl->ana_work); +#endif } /* -- 2.39.5