From: Ian Rogers <irogers@google.com>
To: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Caleb Biggers" <caleb.biggers@intel.com>,
"Weilin Wang" <weilin.wang@intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
"Perry Taylor" <perry.taylor@intel.com>,
"Thomas Falcon" <thomas.falcon@intel.com>
Subject: [PATCH v5 06/16] perf intel-tpebs: Reduce scope of tpebs_events_size
Date: Mon, 14 Apr 2025 10:41:24 -0700 [thread overview]
Message-ID: <20250414174134.3095492-7-irogers@google.com> (raw)
In-Reply-To: <20250414174134.3095492-1-irogers@google.com>
Moved to record argument computation rather than being global.
Signed-off-by: Ian Rogers <irogers@google.com>
Tested-by: Weilin Wang <weilin.wang@intel.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/intel-tpebs.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/intel-tpebs.c b/tools/perf/util/intel-tpebs.c
index 2b04deaf66ff..e3bed86145b9 100644
--- a/tools/perf/util/intel-tpebs.c
+++ b/tools/perf/util/intel-tpebs.c
@@ -29,7 +29,6 @@
#define PERF_DATA "-"
bool tpebs_recording;
-static size_t tpebs_event_size;
static LIST_HEAD(tpebs_results);
static pthread_t tpebs_reader_thread;
static struct child_process tpebs_cmd;
@@ -86,15 +85,20 @@ static int get_perf_record_args(const char **record_argv, char buf[],
static int evsel__tpebs_start_perf_record(struct evsel *evsel, int control_fd[], int ack_fd[])
{
const char **record_argv;
+ size_t tpebs_event_size = 0;
int ret;
char buf[32];
char cpumap_buf[50];
+ struct tpebs_retire_lat *t;
cpu_map__snprint(evsel->evlist->core.user_requested_cpus, cpumap_buf,
sizeof(cpumap_buf));
scnprintf(buf, sizeof(buf), "--control=fd:%d,%d", control_fd[0], ack_fd[1]);
+ list_for_each_entry(t, &tpebs_results, nd)
+ tpebs_event_size++;
+
record_argv = calloc(12 + 2 * tpebs_event_size, sizeof(char *));
if (!record_argv)
return -ENOMEM;
@@ -226,7 +230,6 @@ static struct tpebs_retire_lat *tpebs_retire_lat__new(struct evsel *evsel)
return NULL;
}
list_add_tail(&result->nd, &tpebs_results);
- tpebs_event_size++;
return result;
}
@@ -289,7 +292,7 @@ int evsel__tpebs_open(struct evsel *evsel)
if (ret)
return ret;
- if (tpebs_event_size > 0) {
+ if (!list_empty(&tpebs_results)) {
struct pollfd pollfd = { .events = POLLIN, };
int control_fd[2], ack_fd[2], len;
char ack_buf[8];
--
2.49.0.604.gff1f9ca942-goog
next prev parent reply other threads:[~2025-04-14 17:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 17:41 [PATCH v5 00/16] Intel TPEBS min/max/mean/last support Ian Rogers
2025-04-14 17:41 ` [PATCH v5 01/16] perf intel-tpebs: Cleanup header Ian Rogers
2025-04-14 17:41 ` [PATCH v5 02/16] perf intel-tpebs: Simplify tpebs_cmd Ian Rogers
2025-04-14 17:41 ` [PATCH v5 03/16] perf intel-tpebs: Rename tpebs_start to evsel__tpebs_open Ian Rogers
2025-04-14 17:41 ` [PATCH v5 04/16] perf intel-tpebs: Separate evsel__tpebs_prepare out of evsel__tpebs_open Ian Rogers
2025-04-14 17:41 ` [PATCH v5 05/16] perf intel-tpebs: Move cpumap_buf " Ian Rogers
2025-04-14 17:41 ` Ian Rogers [this message]
2025-04-14 17:41 ` [PATCH v5 07/16] perf intel-tpebs: Inline get_perf_record_args Ian Rogers
2025-04-14 17:41 ` [PATCH v5 08/16] perf intel-tpebs: Ensure events are opened, factor out finding Ian Rogers
2025-04-14 17:41 ` [PATCH v5 09/16] perf intel-tpebs: Refactor tpebs_results list Ian Rogers
2025-04-23 14:23 ` Arnaldo Carvalho de Melo
2025-04-23 15:04 ` Ian Rogers
2025-04-14 17:41 ` [PATCH v5 10/16] perf intel-tpebs: Add support for updating counts in evsel__tpebs_read Ian Rogers
2025-04-14 17:41 ` [PATCH v5 11/16] perf intel-tpebs: Add mutex for tpebs_results Ian Rogers
2025-04-14 17:41 ` [PATCH v5 12/16] perf intel-tpebs: Don't close record on read Ian Rogers
2025-04-14 17:41 ` [PATCH v5 13/16] perf intel-tpebs: Use stats for retirement latency statistics Ian Rogers
2025-04-14 17:41 ` [PATCH v5 14/16] perf stat: Add mean, min, max and last --tpebs-mode options Ian Rogers
2025-04-23 13:56 ` Arnaldo Carvalho de Melo
2025-04-23 15:03 ` Ian Rogers
2025-04-14 17:41 ` [PATCH v5 15/16] perf pmu-events: Add retirement latency to JSON events inside of perf Ian Rogers
2025-04-14 17:41 ` [PATCH v5 16/16] perf record: Retirement latency cleanup in evsel__config Ian Rogers
2025-04-14 19:08 ` [PATCH v5 00/16] Intel TPEBS min/max/mean/last support Liang, Kan
2025-04-21 18:13 ` Ian Rogers
2025-04-23 13:33 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250414174134.3095492-7-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=afaerber@suse.de \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=caleb.biggers@intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=thomas.falcon@intel.com \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®