mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sagi Shahar <sagis@google.com>
To: linux-kselftest@vger.kernel.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	 Shuah Khan <shuah@kernel.org>,
	Sean Christopherson <seanjc@google.com>,
	 Ackerley Tng <ackerleytng@google.com>,
	Ryan Afranji <afranji@google.com>,
	 Andrew Jones <ajones@ventanamicro.com>,
	Isaku Yamahata <isaku.yamahata@intel.com>,
	 Erdem Aktas <erdemaktas@google.com>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	 Sagi Shahar <sagis@google.com>,
	Roger Wang <runanwang@google.com>,
	 Binbin Wu <binbin.wu@linux.intel.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	 "Pratik R. Sampat" <pratikrajesh.sampat@amd.com>,
	Reinette Chatre <reinette.chatre@intel.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: [PATCH v6 07/30] KVM: selftests: TDX: Use KVM_TDX_CAPABILITIES to validate TDs' attribute configuration
Date: Mon, 14 Apr 2025 14:47:36 -0700	[thread overview]
Message-ID: <20250414214801.2693294-8-sagis@google.com> (raw)
In-Reply-To: <20250414214801.2693294-1-sagis@google.com>

From: Ackerley Tng <ackerleytng@google.com>

This also exercises the KVM_TDX_CAPABILITIES ioctl.

Suggested-by: Isaku Yamahata <isaku.yamahata@intel.com>
Co-developed-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Ackerley Tng <ackerleytng@google.com>
Signed-off-by: Sagi Shahar <sagis@google.com>
---
 .../selftests/kvm/lib/x86/tdx/tdx_util.c        | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c b/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c
index 392d6272d17e..bb074af4a476 100644
--- a/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c
+++ b/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c
@@ -140,6 +140,21 @@ static void tdx_apply_cpuid_restrictions(struct kvm_cpuid2 *cpuid_data)
 	}
 }
 
+static void tdx_check_attributes(struct kvm_vm *vm, uint64_t attributes)
+{
+	struct kvm_tdx_capabilities *tdx_cap;
+
+	tdx_cap = tdx_read_capabilities(vm);
+
+	/* TDX spec: any bits 0 in supported_attrs must be 0 in attributes */
+	TEST_ASSERT_EQ(attributes & ~tdx_cap->supported_attrs, 0);
+
+	/* TDX spec: any bits 1 in attributes must be 1 in supported_attrs */
+	TEST_ASSERT_EQ(attributes & tdx_cap->supported_attrs, attributes);
+
+	free(tdx_cap);
+}
+
 #define KVM_MAX_CPUID_ENTRIES 256
 
 #define CPUID_EXT_VMX			BIT(5)
@@ -256,6 +271,8 @@ static void tdx_td_init(struct kvm_vm *vm, uint64_t attributes)
 	memcpy(&init_vm->cpuid, cpuid, kvm_cpuid2_size(cpuid->nent));
 	free(cpuid);
 
+	tdx_check_attributes(vm, attributes);
+
 	init_vm->attributes = attributes;
 
 	tdx_apply_cpuid_restrictions(&init_vm->cpuid);
-- 
2.49.0.504.g3bcea36a83-goog


  parent reply	other threads:[~2025-04-14 21:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 21:47 [PATCH v6 00/30] TDX KVM selftests Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 01/30] KVM: selftests: Add function to allow one-to-one GVA to GPA mappings Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 02/30] KVM: selftests: Expose function that sets up sregs based on VM's mode Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 03/30] KVM: selftests: Store initial stack address in struct kvm_vcpu Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 04/30] KVM: selftests: Add vCPU descriptor table initialization utility Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 05/30] KVM: selftests: Update kvm_init_vm_address_properties() for TDX Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 06/30] KVM: selftests: Add helper functions to create TDX VMs Sagi Shahar
2025-04-14 21:47 ` Sagi Shahar [this message]
2025-04-14 21:47 ` [PATCH v6 08/30] KVM: selftests: TDX: Update load_td_memory_region() for VM memory backed by guest memfd Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 09/30] KVM: selftests: TDX: Add TDX lifecycle test Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 10/30] KVM: selftests: TDX: Add report_fatal_error test Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 11/30] KVM: selftests: TDX: Adding test case for TDX port IO Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 12/30] KVM: selftests: TDX: Add basic TDX CPUID test Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 13/30] KVM: selftests: TDX: Add basic TDG.VP.VMCALL<GetTdVmCallInfo> test Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 14/30] KVM: selftests: TDX: Add TDX IO writes test Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 15/30] KVM: selftests: TDX: Add TDX IO reads test Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 16/30] KVM: selftests: TDX: Add TDX MSR read/write tests Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 17/30] KVM: selftests: TDX: Add TDX HLT exit test Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 18/30] KVM: selftests: TDX: Add TDX MMIO reads test Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 19/30] KVM: selftests: TDX: Add TDX MMIO writes test Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 20/30] KVM: selftests: TDX: Add TDX CPUID TDVMCALL test Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 21/30] KVM: selftests: TDX: Verify the behavior when host consumes a TD private memory Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 22/30] KVM: selftests: TDX: Add TDG.VP.INFO test Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 23/30] KVM: selftests: Add functions to allow mapping as shared Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 24/30] KVM: selftests: TDX: Add shared memory test Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 25/30] KVM: selftests: KVM: selftests: Expose new vm_vaddr_alloc_private() Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 26/30] KVM: selftests: TDX: Add support for TDG.MEM.PAGE.ACCEPT Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 27/30] KVM: selftests: TDX: Add support for TDG.VP.VEINFO.GET Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 28/30] KVM: selftests: TDX: Add TDX UPM selftest Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 29/30] KVM: selftests: TDX: Add TDX UPM selftests for implicit conversion Sagi Shahar
2025-04-14 21:47 ` [PATCH v6 30/30] KVM: selftests: TDX: Test LOG_DIRTY_PAGES flag to a non-GUEST_MEMFD memslot Sagi Shahar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250414214801.2693294-8-sagis@google.com \
    --to=sagis@google.com \
    --cc=ackerleytng@google.com \
    --cc=afranji@google.com \
    --cc=ajones@ventanamicro.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=erdemaktas@google.com \
    --cc=isaku.yamahata@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=pratikrajesh.sampat@amd.com \
    --cc=reinette.chatre@intel.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=runanwang@google.com \
    --cc=seanjc@google.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®