From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2863E22ACCE for ; Wed, 16 Apr 2025 20:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744835214; cv=none; b=cdAVWs8FbADwBKzxRPDMl10QVMHXS5JsZXMrv6fmyJWZfhHVcz/9S/yo588SlolYLc9cHovYg14feZd1teyixvJh1Hmg8rqqFEx9+XcWME/RTlua77pucPixnwUbXCt5MUHlSgvMgKbvaEtuO8bIBQXjKnwev8eMy3GwDC06ADI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744835214; c=relaxed/simple; bh=+NVEIDajjOa6S0mwO8uDhLAW9+C2KQqJgF0nDKTn3hM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TDQpSzVeipS9pSDSLcap2yVxFPhuKClWlBN81XxK1mgs636c9A0WIddNV4zkQfmY++YQgbOzklGzBlp8kjs5xGl4m5dJ5t6XV+5VgTxjeE6OUk0bMeTKDQp74drZINy6ardAolZEPyIHmXYmLgWVH9/MPWk4nljsqUFN1tftUdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RCYhSEOE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RCYhSEOE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744835211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d6AVDplNPTi289CSbOZ9ARQJAN0z0vy8/1A9VIws9D4=; b=RCYhSEOE5TW5+f/LnBvQMv6DknVVz8scVPOgDyL8qgEneaZfPvLcfQE4sLJ7lqCcl2QAfy JxJXkL014ODn+fCdDFI291Twh12llkrYsY6U9Xg6qWFiKme3hPI/FZcLLPsytnM33fpy0C ehraFsC5kg6xf4e3o9MeNcEEYpJq8Oo= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-224-nzEbTNQ0OzKTGsPaBIevZQ-1; Wed, 16 Apr 2025 16:26:50 -0400 X-MC-Unique: nzEbTNQ0OzKTGsPaBIevZQ-1 X-Mimecast-MFC-AGG-ID: nzEbTNQ0OzKTGsPaBIevZQ_1744835210 Received: by mail-io1-f70.google.com with SMTP id ca18e2360f4ac-85b46c0e605so842439f.0 for ; Wed, 16 Apr 2025 13:26:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744835210; x=1745440010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d6AVDplNPTi289CSbOZ9ARQJAN0z0vy8/1A9VIws9D4=; b=A2AJfRbcCN6NnEZBLFh/Z6Rb93lamjOgh/sN43+GHVkSX3CMkAofgQfmW1lpFAlwEX i+afEQpboFBC+9p9rlQZ7eqoSZrLyHFO8F192X9OCHyY2vQY1GHWvUAqHfheLwDWSV/m kmz/lYepwHUtLvtb5YLcEUf6JwyIgTifG/r+mxIJs309cqwyIPrxZvjqlPgzdTuca02H LIghnvlffrzDMQKsQqyFZcE2hHKXUvWpSeU2ZaZ9HcNFrPA1bLu2hUje5NObJbgz1eQQ 57iCStvEb7I5bLFVbbau6hPUv1+QCawMIncvvpcYSTpzv+mlKv+lcZhR2VFQ6t1OppkA gtFA== X-Forwarded-Encrypted: i=1; AJvYcCXAq2s6l165vjXRtoBJgJD8Y03P/s/QcKcn/HmDDgquYtC5GJtDxhnYSPnlU5fkrmg0wNMDD/wgNtxw+cU=@vger.kernel.org X-Gm-Message-State: AOJu0YzH9/guvcTYekfxq+Txr86qYo9hjcPIzMkhjmXEisvAp9ZDeyue ZWUNxqhUBLh8F8yYA6KSl9fSSD8T5Iroryry0s7I9W/3NIJ0lsPKvDBKa5vrLkyXak5YiKz2Fh4 hU89gZmekHYxjAR4qEKwMHb1nl6Ri+pQ/7kNsTS9oFdmzFHe9K7Cj85EkmyRpVg== X-Gm-Gg: ASbGncum+ULxqfmJ7t4zyMQ+OwCOdxBM1lSp6BidtwNyq9kXty9Uuu/tWasWtZH3xf8 FNo1bW+4MmofMbG7hw3Uuh1fNCD5wco7cwXc3XE2hby0DJRl0BF47gJD6xEX9Fi9lnOvn91Ygse hF06Qr+8RsKT8Rv2TsJi6HBDFlAHvnlvOHeP8NKtR/gerfHMdV2UAxDNS09TQXJUKoAZTpSIdI7 6/6G5ULfg4gazwy0QaJsmKQQEQaJqtimLoh6/j/9cUyv++YfkSkjJa9DfLo4miYcOMPlEG9DYsl TNSh3ub8z20ByCo= X-Received: by 2002:a05:6602:1583:b0:856:2a52:ea02 with SMTP id ca18e2360f4ac-861cc5cfb48mr34533939f.5.1744835209678; Wed, 16 Apr 2025 13:26:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdbc3yXRCu1SxHof01X2wIaipkMkSkrZJncD3XrTLmdj2ulJ1ktFsxzmI+33GyeGFuM7i9VQ== X-Received: by 2002:a05:6602:1583:b0:856:2a52:ea02 with SMTP id ca18e2360f4ac-861cc5cfb48mr34532239f.5.1744835209342; Wed, 16 Apr 2025 13:26:49 -0700 (PDT) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-8616522d048sm306863539f.1.2025.04.16.13.26.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:26:48 -0700 (PDT) Date: Wed, 16 Apr 2025 14:26:45 -0600 From: Alex Williamson To: Salvatore Bonaccorso Cc: David Howells , Christoph Hellwig , David Hildenbrand , Lorenzo Stoakes , Andrew Morton , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , Sasha Levin , Greg Kroah-Hartman , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, regressions@lists.linux.dev, table@vger.kernel.org, Bernd Rinn , Karri =?UTF-8?B?SMOkbcOkbMOkaW5lbg==?= , Milan Broz , Cameron Davidson , Markus Subject: Re: [regression 6.1.y] Regression from 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in pin_user_pages()") with pci-passthrough for both KVM VMs and booting in xen DomU Message-ID: <20250416142645.4392a644.alex.williamson@redhat.com> In-Reply-To: References: X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 15 Apr 2025 20:59:19 +0200 Salvatore Bonaccorso wrote: > Hi > > [Apologies if this has been reported already but I have not found an > already filled corresponding report] > > After updating from the 6.1.129 based version to 6.1.133, various > users have reported that their VMs do not boot anymore up (both KVM > and under Xen) if pci-passthrough is involved. The reports are at: > > https://bugs.debian.org/1102889 > https://bugs.debian.org/1102914 > https://bugs.debian.org/1103153 > > Milan Broz bisected the issues and found that the commit introducing > the problems can be tracked down to backport of c8070b787519 ("mm: > Don't pin ZERO_PAGE in pin_user_pages()") from 6.5-rc1 which got > backported as 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in > pin_user_pages()") in 6.1.130. See https://bugs.debian.org/1102914#60 > > #regzbot introduced: 476c1dfefab8b98ae9c3e3ad283c2ac10d30c774 > > 476c1dfefab8b98ae9c3e3ad283c2ac10d30c774 is the first bad commit > commit 476c1dfefab8b98ae9c3e3ad283c2ac10d30c774 > Author: David Howells > Date: Fri May 26 22:41:40 2023 +0100 > > mm: Don't pin ZERO_PAGE in pin_user_pages() > > [ Upstream commit c8070b78751955e59b42457b974bea4a4fe00187 ] It's a bad backport, I've debugged and posted the fix for stable here: https://lore.kernel.org/all/20250416202441.3911142-1-alex.williamson@redhat.com/ Thanks, Alex