mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Luo Gengkun <luogengkun@huaweicloud.com>
Cc: joel.granados@kernel.org, song@kernel.org, dianders@chromium.org,
	tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: Fix watchdog may detect false positive of softlockup
Date: Wed, 16 Apr 2025 16:39:39 -0700	[thread overview]
Message-ID: <20250416163939.7a3670b83d9f9ba56680516c@linux-foundation.org> (raw)
In-Reply-To: <a56803dd-0e38-4edc-b1a1-f850246f210b@huaweicloud.com>

On Wed, 16 Apr 2025 14:44:52 +0800 Luo Gengkun <luogengkun@huaweicloud.com> wrote:

> The following testcase may help to understand this problem.

OK.  Please

a) include this info in the v2 changelog

b) consider whether you believe the fix should be backported into
   -stable kernels and if so, add a Cc: <stable@vger.kernel.org> and,
   if appropriate, add a Fixes: target

c) Place a couple of comments in the code to help readers understand
   why we're doing this

d) try to amke the changelog a little less puzzling ;)

e) retest and resend!

Thanks.

      reply	other threads:[~2025-04-16 23:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-16  1:39 Luo Gengkun
2025-04-16  2:31 ` Andrew Morton
2025-04-16  6:44   ` Luo Gengkun
2025-04-16 23:39     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250416163939.7a3670b83d9f9ba56680516c@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dianders@chromium.org \
    --cc=joel.granados@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luogengkun@huaweicloud.com \
    --cc=song@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®