mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Libo Chen <libo.chen@oracle.com>
Cc: peterz@infradead.org, mgorman@suse.de, mingo@redhat.com,
	juri.lelli@redhat.com, vincent.guittot@linaro.org, tj@kernel.org,
	rostedt@goodmis.org, llong@redhat.com, kprateek.nayak@amd.com,
	raghavendra.kt@amd.com, yu.c.chen@intel.com,
	tim.c.chen@intel.com, vineethr@linux.ibm.com,
	chris.hyser@oracle.com, daniel.m.jordan@oracle.com,
	lorenzo.stoakes@oracle.com, mkoutny@suse.com,
	Dhaval.Giani@amd.com, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] sched/numa: Skip VMA scanning on memory pinned
Date: Thu, 17 Apr 2025 13:12:36 -0700	[thread overview]
Message-ID: <20250417131236.c47ce477c0e68dbb06a4fabb@linux-foundation.org> (raw)
In-Reply-To: <20250417191543.1781862-1-libo.chen@oracle.com>

On Thu, 17 Apr 2025 12:15:41 -0700 Libo Chen <libo.chen@oracle.com> wrote:

> v1->v2:
> 1. add perf improvment numbers in commit log. Yet to find perf diff on
> will-it-scale, so not included here. Plan to run more workloads.
> 2. add tracepoint.
> 3. To peterz's comment, this will make it impossible to attract tasks to
> those memory just like other VMA skippings. This is the current
> implementation, I think we can improve that in the future, but at the
> moment it's probabaly better to keep it consistent.
> 
> v2->v3:
> 1. add enable_cpuset() based on Mel's suggestion but again I think it's
> redundant
> 2. print out nodemask with %*p.. format in the tracepoint

I do agree with Mel - bitmap_weight() is somewhat expensive and
cpusets_enabled() is super fast.  So the benefit to
cpusets_enabled()=false kernels will exceed to cost to
cpusets_enabled()=true kernels.

This isn't traditionally mm.git material, but it's close.  I'll grab
the patchset for some testing.  and shall drop it again if it turns up
via another tree.

  parent reply	other threads:[~2025-04-17 20:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17 19:15 Libo Chen
2025-04-17 19:15 ` [PATCH v3 1/2] sched/numa: Skip VMA scanning on memory pinned to one NUMA node via cpuset.mems Libo Chen
2025-04-19 11:16   ` Chen, Yu C
2025-04-22 22:20     ` Libo Chen
2025-04-22 23:27       ` Chen, Yu C
2025-04-17 19:15 ` [PATCH v3 2/2] sched/numa: Add tracepoint that tracks the skipping of numa balancing due to cpuset memory pinning Libo Chen
2025-04-23 15:34   ` Steven Rostedt
2025-04-23 16:05     ` Libo Chen
2025-04-23 16:12       ` Steven Rostedt
2025-04-23 16:50         ` Libo Chen
2025-04-23 16:56           ` Steven Rostedt
2025-04-23 16:57             ` Steven Rostedt
2025-04-23 18:22             ` Libo Chen
2025-04-17 20:12 ` Andrew Morton [this message]
2025-04-17 21:07   ` [PATCH v3 0/2] sched/numa: Skip VMA scanning on memory pinned Libo Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250417131236.c47ce477c0e68dbb06a4fabb@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Dhaval.Giani@amd.com \
    --cc=cgroups@vger.kernel.org \
    --cc=chris.hyser@oracle.com \
    --cc=daniel.m.jordan@oracle.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=libo.chen@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llong@redhat.com \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=peterz@infradead.org \
    --cc=raghavendra.kt@amd.com \
    --cc=rostedt@goodmis.org \
    --cc=tim.c.chen@intel.com \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vineethr@linux.ibm.com \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®